feat(inspector): accept bare host and bare port for --inspect flag#31881
Merged
bartlomieju merged 5 commits intodenoland:mainfrom Jan 20, 2026
Merged
feat(inspector): accept bare host and bare port for --inspect flag#31881bartlomieju merged 5 commits intodenoland:mainfrom
bartlomieju merged 5 commits intodenoland:mainfrom
Conversation
dsherret
reviewed
Jan 18, 2026
bartlomieju
commented
Jan 18, 2026
| let tcp_listener = std::net::TcpListener::bind(host) | ||
| .map_err(|source| InspectorServerError::Connect { host, source })?; | ||
| tcp_listener.set_nonblocking(true)?; | ||
| // TODO(bartlomieju): update process wide inspector server host |
Member
Author
There was a problem hiding this comment.
This is a TODO for a future PR - I'll address once working on #31863
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit changes arg parsing for
--inspect,--inspect-brkand--inspect-waitflagto allow passing values as follows:
127.0.0.1->127.0.0.1:9229192.168.0.1->192.168.0.1:9229:10000->127.0.0.1:1000010000->127.0.0.1:10000:0->127.0.0.1:<OS assigned port>0->127.0.0.1:<OS assigned port>This matches what Node.js is doing and will help to solve test compatiblity discovered in fix(ext/node): set process.features.inspector #31863.