fix(ext/node): add chown method to FileHandle class#27638
Merged
kt3k merged 5 commits intodenoland:mainfrom Jan 15, 2025
Merged
fix(ext/node): add chown method to FileHandle class#27638kt3k merged 5 commits intodenoland:mainfrom
kt3k merged 5 commits intodenoland:mainfrom
Conversation
|
|
Contributor
Author
|
Windows test seems to have failed |
Contributor
Author
|
Similar to #27522, |
kt3k
reviewed
Jan 14, 2025
Comment on lines
+233
to
+240
| try { | ||
| await fileHandle.chown(nobodyUid, nobodyGid); | ||
| } catch (e) { | ||
| assert( | ||
| e instanceof Deno.errors.PermissionDenied, | ||
| "Expected permissionDenied error", | ||
| ); | ||
| } |
Contributor
There was a problem hiding this comment.
Can you use assertRejects instead? This passes when await fileHandle.chown(nobodyUid, nobodyGid) doesn't throw
Contributor
Author
There was a problem hiding this comment.
I didn't know about assertRejects. I will take it.
2f53612 to
9f1c0d8
Compare
kt3k
reviewed
Jan 15, 2025
Signed-off-by: Yoshiya Hinosawa <stibium121@gmail.com>
Contributor
Author
|
test release linux-x86_64 is failed. I don't understand why this test fails. 
|
Contributor
|
Looks like a flaky failure. I'll rerun it |
Contributor
Author
|
CI is passed! |
kt3k
approved these changes
Jan 15, 2025
Contributor
kt3k
left a comment
There was a problem hiding this comment.
LGTM. Thanks for your contribution!
bartlomieju
pushed a commit
that referenced
this pull request
Jan 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a chown method to the FileHandle class #25554.
This is my first PR. if there is anything missing, please let me know so I can fix it.