feat(node/fs): Add a chmod method to the FileHandle class#27522
Merged
marvinhagemeister merged 4 commits intodenoland:mainfrom Jan 7, 2025
Merged
feat(node/fs): Add a chmod method to the FileHandle class#27522marvinhagemeister merged 4 commits intodenoland:mainfrom
marvinhagemeister merged 4 commits intodenoland:mainfrom
Conversation
|
|
Tihana08
approved these changes
Jan 2, 2025
Tihana08
approved these changes
Jan 2, 2025
Contributor
Author
|
Hi @k-nasa, |
Contributor
marvinhagemeister
left a comment
There was a problem hiding this comment.
LGTM, left two minor nits. You can resolve these by running
./tools/format.js
Contributor
Author
|
@marvinhagemeister thanks, ran the format script and fixed those + couple other semicolons. |
Contributor
Author
|
It looks like the test is failing in the windows build. 
This is working in the mac and linux tests, any ideas? |
f150fe8 to
5a7a2c9
Compare
Contributor
|
Running a quick |
Contributor
Author
|
Thanks @marvinhagemeister, this should be ready |
0cba694 to
2894a43
Compare
Fix windows unsupported mode number Fix windows tests Use modes that windows can handle use more open modes for windows
As the underlying implementation of chmod is not tested on windows, there is no reason to test this one as well.
2894a43 to
cb613d1
Compare
marvinhagemeister
approved these changes
Jan 7, 2025
dsherret
pushed a commit
that referenced
this pull request
Jan 9, 2025
Add the chmod method to the FileHandle class in node compat as part of #25554
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the chmod method to the FileHandle class in node compat as part of #25554