Skip to content

fix(ext/node): add writev method to FileHandle#27563

Merged
kt3k merged 6 commits intodenoland:mainfrom
aaron-ang:aaron-ang/filehandle-writev
Jan 14, 2025
Merged

fix(ext/node): add writev method to FileHandle#27563
kt3k merged 6 commits intodenoland:mainfrom
aaron-ang:aaron-ang/filehandle-writev

Conversation

@aaron-ang
Copy link
Copy Markdown
Contributor

@aaron-ang aaron-ang commented Jan 6, 2025

Part of #25554

I merged _fs_writev.mjs and _fs_writev.d.ts into _fs_writev.ts

  • formatted using ./tools/format.js
  • linted using ./tools/lint.js
  • unit test passed in tests/unit_node/_fs/_fs_handle_test.ts

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jan 6, 2025

CLA assistant check
All committers have signed the CLA.

@aaron-ang aaron-ang changed the title fix(ext/node): add writev method to FileHandle feat(ext/node): add writev method to FileHandle Jan 6, 2025
@dsherret dsherret requested a review from kt3k January 8, 2025 22:09
Signed-off-by: Aaron Ang <67321817+aaron-ang@users.noreply.github.com>
@kt3k kt3k mentioned this pull request Jan 14, 2025
24 tasks
@kt3k
Copy link
Copy Markdown
Contributor

kt3k commented Jan 14, 2025

I merged _fs_writev.mjs and _fs_writev.d.ts into _fs_writev.ts

_fs_writev.mjs was originally added in denoland/std#2008 without special reason to use .mjs. This move seems fine to me.

@kt3k kt3k changed the title feat(ext/node): add writev method to FileHandle fix(ext/node): add writev method to FileHandle Jan 14, 2025
Copy link
Copy Markdown
Contributor

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kt3k kt3k merged commit 9cb089f into denoland:main Jan 14, 2025
@aaron-ang aaron-ang deleted the aaron-ang/filehandle-writev branch January 14, 2025 10:24
bartlomieju pushed a commit that referenced this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants