feat(node/_fs): Add fs.writev(fd, buffers[, position], callback)#2008
Merged
kt3k merged 6 commits intodenoland:mainfrom Mar 9, 2022
Merged
feat(node/_fs): Add fs.writev(fd, buffers[, position], callback)#2008kt3k merged 6 commits intodenoland:mainfrom
fs.writev(fd, buffers[, position], callback)#2008kt3k merged 6 commits intodenoland:mainfrom
Conversation
kt3k
reviewed
Mar 8, 2022
Contributor
|
@getspooky Thank you for working on this! Can you add some test cases? |
kt3k
reviewed
Mar 8, 2022
| "test-fs-write-stream.js", | ||
| "test-fs-write-sync.js", | ||
| "test-fs-write.js", | ||
| "test-fs-writev.js", |
Contributor
|
Please merge main branch when #2012 is landed. That should fix the CI checks |
Contributor
Author
|
@kt3k can you pls merge that, i need it to continue working on |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #1863
denoland/deno#18218