Skip to content

docs: fix doc testing errors#2012

Merged
kt3k merged 3 commits intodenoland:mainfrom
kt3k:fix/fix-doc-testing
Mar 8, 2022
Merged

docs: fix doc testing errors#2012
kt3k merged 3 commits intodenoland:mainfrom
kt3k:fix/fix-doc-testing

Conversation

@kt3k
Copy link
Copy Markdown
Contributor

@kt3k kt3k commented Mar 8, 2022

CLI canary started recognizing javascript and typescript as language tags for markdown code blocks at denoland/deno#13785, and that caused some of new type errors in std's doc testing.

This PR fixes it.

@kt3k kt3k requested a review from bartlomieju as a code owner March 8, 2022 15:42
Copy link
Copy Markdown
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k
Copy link
Copy Markdown
Contributor Author

kt3k commented Mar 8, 2022

npm install test case is failing again.. I'll skip that for now

@kt3k
Copy link
Copy Markdown
Contributor Author

kt3k commented Mar 8, 2022

npm install test case is failing again.. I'll skip that for now

Created issue for tracking this #2013

@bartlomieju
Copy link
Copy Markdown
Member

I believe I hit that flake yesterday too. Is that a problem with our code?

@kt3k
Copy link
Copy Markdown
Contributor Author

kt3k commented Mar 8, 2022

It seems trying to look up wrong path while processing postinstall according to the error logs like the below:

npm ERR! code 1
npm ERR! path /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/5ac69842/node_modules/es5-ext
npm ERR! command failed
npm ERR! command sh -c node ./_postinstall.js
npm ERR! node:internal/modules/cjs/loader:936
npm ERR!   throw err;
npm ERR!   ^
npm ERR! 
npm ERR! Error: Cannot find module '/private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/5ac69842/_postinstall.js'

I guess look-up algorithm, handling of cwd, or something is wrong. I'll try look into more details tomorrow.

@kt3k kt3k merged commit 2ec5e07 into denoland:main Mar 8, 2022
@kt3k kt3k deleted the fix/fix-doc-testing branch March 8, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants