Skip to content

fix(test): typecheck blocks annotated with long js/ts notations#13785

Merged
bartlomieju merged 9 commits intodenoland:mainfrom
GJZwiers:typecheck_docs_with_full_typescript_annotation
Mar 8, 2022
Merged

fix(test): typecheck blocks annotated with long js/ts notations#13785
bartlomieju merged 9 commits intodenoland:mainfrom
GJZwiers:typecheck_docs_with_full_typescript_annotation

Conversation

@GJZwiers
Copy link
Copy Markdown
Contributor

@GJZwiers GJZwiers commented Feb 27, 2022 •
edited
Loading

Closes #13783

@GJZwiers GJZwiers changed the title fix(test): typecheck blocks annotated with long js/ts notations WIP: fix(test): typecheck blocks annotated with long js/ts notations Feb 27, 2022
@bartlomieju
Copy link
Copy Markdown
Member

bartlomieju commented Mar 1, 2022

@GJZwiers looks good! The test failure seems to be unrelated. Could you add some test case to exercise this change?

@GJZwiers
Copy link
Copy Markdown
Contributor Author

GJZwiers commented Mar 2, 2022 •
edited
Loading

@GJZwiers looks good! The test failure seems to be unrelated. Could you add some test case to exercise this change?

I've added a test, the pipeline keeps failing on a few compat tests but other than that it seems fine. Will this be OK?

@GJZwiers GJZwiers changed the title WIP: fix(test): typecheck blocks annotated with long js/ts notations fix(test): typecheck blocks annotated with long js/ts notations Mar 2, 2022
@bartlomieju
Copy link
Copy Markdown
Member

bartlomieju commented Mar 8, 2022

@GJZwiers it seems the errors were coming from test_util/std git submodule which was mistakenly changed in this PR. I reverted that change and tests seem to pass locally now.

@bartlomieju bartlomieju mentioned this pull request Mar 8, 2022
Merged
bartlomieju
bartlomieju approved these changes Mar 8, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@bartlomieju bartlomieju merged commit e53b6c1 into denoland:main Mar 8, 2022
@kt3k kt3k mentioned this pull request Mar 8, 2022
Merged
kt3k pushed a commit that referenced this pull request Mar 10, 2022
@GJZwiers @kt3k
fix(test): typecheck blocks annotated with long js/ts notations (#13785)
8cab5d8
@GJZwiers GJZwiers deleted the typecheck_docs_with_full_typescript_annotation branch March 11, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@dsherret dsherret Awaiting requested review from dsherret

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

deno test --doc doesn't pick up typescript-annotated blocks

2 participants

@GJZwiers @bartlomieju