Skip to content

Multi-tenant modifications#466

Merged
shaynafinocchiaro merged 2 commits into
mainfrom
multi-tenant-modifications
Aug 20, 2025
Merged

Multi-tenant modifications#466
shaynafinocchiaro merged 2 commits into
mainfrom
multi-tenant-modifications

Conversation

@shaynafinocchiaro

@shaynafinocchiaro shaynafinocchiaro commented Aug 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

Port over changes from #463 and #464.

  • Reconcile node labels on start up if feature is not disabled.
  • Updated node label matching to check if the IP in the node label is in the range of CIDR instead of checking with the IP/netmask from the label.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1991

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • UT
  • Removed node labels, immediately on installing driver labels are added back

@github-actions

github-actions Bot commented Aug 20, 2025

Copy link
Copy Markdown
Contributor

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/csi-powerscale/csi-utils 0.00% (ø)
github.com/dell/csi-powerscale/service 0.00% (ø)
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/csi-powerscale/csi-utils/csiutils.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerscale/service/controller.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerscale/service/service.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/dell/csi-powerscale/csi-utils/csiutils_test.go
  • github.com/dell/csi-powerscale/service/controller_test.go
  • github.com/dell/csi-powerscale/service/service_test.go

@shaynafinocchiaro shaynafinocchiaro marked this pull request as ready for review August 20, 2025 16:54
@shaynafinocchiaro shaynafinocchiaro merged commit 54f492d into main Aug 20, 2025
6 checks passed
@shaynafinocchiaro shaynafinocchiaro deleted the multi-tenant-modifications branch August 20, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alikdell alikdell alikdell approved these changes

@atye atye Awaiting requested review from atye

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004

@chimanjain chimanjain Awaiting requested review from chimanjain

@ChristianAtDell ChristianAtDell Awaiting requested review from ChristianAtDell

@HarishH-DELL HarishH-DELL Awaiting requested review from HarishH-DELL

@meggm meggm Awaiting requested review from meggm

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani

@Sakshi-dell Sakshi-dell Awaiting requested review from Sakshi-dell

@santhoshatdell santhoshatdell Awaiting requested review from santhoshatdell

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra

+1 more reviewer

@donatwork donatwork donatwork approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shaynafinocchiaro @donatwork @alikdell @OliverChen557