Modify reconcile to run on driver initialization#463
Merged
Conversation
tdawe
reviewed
Aug 19, 2025
| azReconcileInterval := r.service.getReconcileInterval() | ||
|
|
||
| // On first iteration, reconcile labels then start the ticker | ||
| if azReconcileInterval > 0 { |
Contributor
There was a problem hiding this comment.
We should return early if azReconcileInterval == 0.
if azReconcileInterval == 0 {
log.Info("Reconcile is invalid value of 0. Must be greater than 0 to enable label reconciler.")
return nil
}
Collaborator
Author
There was a problem hiding this comment.
That's being checked here https://github.com/dell/csi-powerscale/blob/main/service/service.go#L907, is that okay?
Contributor
There was a problem hiding this comment.
We need the check here too or else if azReconcileInterval = 0, it will still go into the go routine below and create a ticker with interval of 0:
ticker := time.NewTicker(r.service.getReconcileInterval())
Contributor
There was a problem hiding this comment.
It also follows the pattern of returning early and doesn't require use of an else statement: https://danp.net/posts/reducing-go-nesting/
donatwork
approved these changes
Aug 19, 2025
hoppea2
approved these changes
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reconcile node labels on start up if feature is not disabled.
Port over changes from #458
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration