Updated node label matching#464
Merged
Merged
Conversation
donatwork
previously approved these changes
Aug 19, 2025
tdawe
reviewed
Aug 19, 2025
| @@ -1693,12 +1694,11 @@ func (s *service) getIpsFromAZNetworkLabel(ctx context.Context, nodeID, azNetwor | |||
| if match := pattern.FindStringSubmatch(key); len(match) == 4 { | |||
Contributor
There was a problem hiding this comment.
Comments above are incorrect now with updated matching:
- "Find the node label with matching AZNetwork" should be "Find the node label with IP that belongs to AZNetwork"
- "Found the node with the matching AZNetwork label, get its IP" should be "Found the node with IP that belongs to the AZNetwork"
hoppea2
previously approved these changes
Aug 19, 2025
hoppea2
approved these changes
Aug 19, 2025
donatwork
approved these changes
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated node label matching to check if the IP in the node label is in the range of CIDR instead of checking with the IP/netmask from the label.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration