Skip to content

Create Snapshot fix: Get isiPath from source volume's export path#406

Merged
santhoshatdell merged 3 commits into
mainfrom
create-snapshot
Jun 20, 2025
Merged

Create Snapshot fix: Get isiPath from source volume's export path#406
santhoshatdell merged 3 commits into
mainfrom
create-snapshot

Conversation

@santhoshatdell

@santhoshatdell santhoshatdell commented Jun 19, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

For the CreateSnapshot call, the required isiPath is now retrieved from the source volume's export path like it is done in the replication code. So, there will be no need to get PV's 'Path' value or remove any prefix. Hence, reverting the changes made in previous PRs #355 and #383

Related PRs:
dell/csm-operator#1012
dell/helm-charts#753
dell/csm-docs#1573

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1920

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

  • Create snapshot with "volume-name-prefix=csivol" (default).
  • Create snapshot with "volume-name-prefix=k8s".
  • Create snapshot for volume created earlier with different prefix.
  • Create snapshot for replicated PV.
  • Create snapshot for volume with Authorization module enabled.
  • cert-csi tests have passed for driver.
  • Auth E2E tests for Volume & Snapshot have passed.

Logs are attached to the internal ticket ECS01E-526.

@santhoshatdell santhoshatdell mentioned this pull request Jun 19, 2025
Closed
9 tasks
@santhoshatdell santhoshatdell marked this pull request as draft June 19, 2025 19:35
This was referenced Jun 19, 2025
Merged
Merged
@github-actions

github-actions Bot commented Jun 19, 2025

Copy link
Copy Markdown
Contributor

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/csi-powerscale/common/constants 0.00% (ø)
github.com/dell/csi-powerscale/common/utils 0.00% (ø)
github.com/dell/csi-powerscale/service 0.00% (ø)
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/csi-powerscale/common/constants/consts.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerscale/common/constants/envvars.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerscale/common/utils/utils.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerscale/service/controller.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerscale/service/service.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/dell/csi-powerscale/common/utils/utils_test.go
  • github.com/dell/csi-powerscale/service/service_test.go
  • github.com/dell/csi-powerscale/service/step_defs_test.go

@santhoshatdell santhoshatdell marked this pull request as ready for review June 19, 2025 21:58
donatwork
donatwork reviewed Jun 20, 2025
View reviewed changes
Comment thread common/constants/envvars.go
@santhoshatdell santhoshatdell merged commit 2cf0059 into main Jun 20, 2025
6 checks passed
@santhoshatdell santhoshatdell deleted the create-snapshot branch June 20, 2025 21:02
@santhoshatdell santhoshatdell mentioned this pull request Jun 23, 2025
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atye atye Awaiting requested review from atye

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004

@chimanjain chimanjain Awaiting requested review from chimanjain

@ChristianAtDell ChristianAtDell Awaiting requested review from ChristianAtDell

@HarishH-DELL HarishH-DELL Awaiting requested review from HarishH-DELL

@meggm meggm Awaiting requested review from meggm

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani

@Sakshi-dell Sakshi-dell Awaiting requested review from Sakshi-dell

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra

3 more reviewers

@donatwork donatwork donatwork approved these changes

@suryagupta4 suryagupta4 suryagupta4 approved these changes

@niranjan-n1 niranjan-n1 niranjan-n1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@santhoshatdell @donatwork @suryagupta4 @niranjan-n1