Skip to content

Fix for Authorization snapshot issue#383

Merged
niranjan-n1 merged 16 commits into
mainfrom
snapshot_bug
May 7, 2025
Merged

Fix for Authorization snapshot issue#383
niranjan-n1 merged 16 commits into
mainfrom
snapshot_bug

Conversation

@niranjan-n1

@niranjan-n1 niranjan-n1 commented May 5, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

  1. This PR fixes the the way snapshot creation is handled when tenant prefix is added to volume Handle when authorization is enabled.
  2. Added volume prefix as env Variable

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1487

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Snapshot creation manually with authorization and without enabling authorization through both helm and operator
  • Ran cert-csi test for snapshot creation with authorization and without enabling authorization through both helm and operator
  • Ran auth e2e test for Snapshot
    go test -v -count=1 -p 1 -race -run TestSnapshot
  • Ran full e2e tests

Logs:
cert-csi output :
cert-csi-isilon-operator.log
cert-csi-isilon-helm.txt

auth test output:
auth-e2e-snapshot-operator.log
auth-e2e-full-output.log

helm-csiprefix-env

This was referenced May 6, 2025
Merged
Merged
Merged
@niranjan-n1 niranjan-n1 self-assigned this May 6, 2025
@niranjan-n1 niranjan-n1 changed the title Fix for authorization snapshot Authorization snapshot issue May 6, 2025
@niranjan-n1 niranjan-n1 changed the title Authorization snapshot issue Fix for Authorization snapshot issue May 6, 2025
@niranjan-n1 niranjan-n1 marked this pull request as ready for review May 6, 2025 12:22
AkshaySainiDell
AkshaySainiDell reviewed May 7, 2025
View reviewed changes
Comment thread service/service.go
Comment thread service/controller.go Outdated
niranjan-n1 and others added 4 commits May 7, 2025 11:16
@niranjan-n1 @AkshaySainiDell
Update service/service.go
4098048 
Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com>
@niranjan-n1
addressed review comment
f2395cb
@niranjan-n1
addressed review comment
aa0252e
@niranjan-n1
addressed review comment
4900398
@github-actions

github-actions Bot commented May 7, 2025

Copy link
Copy Markdown
Contributor

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/csi-powerscale/common/constants 0.00% (ø)
github.com/dell/csi-powerscale/common/utils 0.00% (ø)
github.com/dell/csi-powerscale/service 0.00% (ø)
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/csi-powerscale/common/constants/consts.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerscale/common/constants/envvars.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerscale/common/utils/utils.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerscale/service/controller.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerscale/service/service.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/dell/csi-powerscale/common/utils/utils_test.go
  • github.com/dell/csi-powerscale/service/service_test.go
  • github.com/dell/csi-powerscale/service/step_defs_test.go

rajkumar-palani
rajkumar-palani approved these changes May 7, 2025
View reviewed changes

@rajkumar-palani rajkumar-palani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@niranjan-n1 niranjan-n1 merged commit a4f96b3 into main May 7, 2025
6 checks passed
@niranjan-n1 niranjan-n1 deleted the snapshot_bug branch May 7, 2025 10:47
@santhoshatdell santhoshatdell mentioned this pull request Jun 19, 2025
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atye atye Awaiting requested review from atye

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004

@chimanjain chimanjain Awaiting requested review from chimanjain

@ChristianAtDell ChristianAtDell Awaiting requested review from ChristianAtDell

@donatwork donatwork Awaiting requested review from donatwork

@HarishH-DELL HarishH-DELL Awaiting requested review from HarishH-DELL

@meggm meggm Awaiting requested review from meggm

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@Sakshi-dell Sakshi-dell Awaiting requested review from Sakshi-dell

@santhoshatdell santhoshatdell Awaiting requested review from santhoshatdell

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra

2 more reviewers

@rajkumar-palani rajkumar-palani rajkumar-palani approved these changes

@AkshaySainiDell AkshaySainiDell AkshaySainiDell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@niranjan-n1 niranjan-n1

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@niranjan-n1 @rajkumar-palani @AkshaySainiDell