Skip to content

Removing csi-vol prefix variable for csi-powerscale template as it is no longer needed#1573

Merged
santhoshatdell merged 2 commits into
mainfrom
create-snapshot-pscale
Jun 23, 2025
Merged

Removing csi-vol prefix variable for csi-powerscale template as it is no longer needed#1573
santhoshatdell merged 2 commits into
mainfrom
create-snapshot-pscale

Conversation

@santhoshatdell

@santhoshatdell santhoshatdell commented Jun 19, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

For the PowerScale CreateSnapshot call, the required isiPath is now retrieved from the source volume's export path like it is done in the replication code. So, there will be no need to get PV's 'Path' value or remove any prefix. Hence, reverting the changes made in previous PR #1521 for 1.15 template.

Related PRs:
dell/csi-powerscale#406
dell/csm-operator#1012
dell/helm-charts#753

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1920

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

This was referenced Jun 19, 2025
Merged
Closed
@github-actions

github-actions Bot commented Jun 19, 2025 •
edited
Loading

Copy link
Copy Markdown

Test Results

79 tests  ±0   79 ✅ ±0   3s ⏱️ ±0s
 3 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 36fd719. ± Comparison against base commit b93a2dc.

♻️ This comment has been updated with latest results.

@santhoshatdell santhoshatdell mentioned this pull request Jun 19, 2025
Merged
15 tasks
@santhoshatdell santhoshatdell marked this pull request as ready for review June 19, 2025 21:58
niranjan-n1
niranjan-n1 previously approved these changes Jun 20, 2025
View reviewed changes
@santhoshatdell santhoshatdell marked this pull request as draft June 20, 2025 16:48
@santhoshatdell santhoshatdell marked this pull request as ready for review June 20, 2025 17:58
@santhoshatdell santhoshatdell mentioned this pull request Jun 23, 2025
Merged
9 tasks
@santhoshatdell santhoshatdell merged commit 68b12d4 into main Jun 23, 2025
8 checks passed
@santhoshatdell santhoshatdell deleted the create-snapshot-pscale branch June 23, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alikdell alikdell alikdell approved these changes

@gallacher gallacher Awaiting requested review from gallacher

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@AronAtDell AronAtDell Awaiting requested review from AronAtDell AronAtDell is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@rsedlock1958 rsedlock1958 Awaiting requested review from rsedlock1958

@anandrajak1 anandrajak1 Awaiting requested review from anandrajak1

@Prabhu-Dell Prabhu-Dell Awaiting requested review from Prabhu-Dell

@adarsh-dell adarsh-dell Awaiting requested review from adarsh-dell

+3 more reviewers

@donatwork donatwork donatwork approved these changes

@suryagupta4 suryagupta4 suryagupta4 approved these changes

@niranjan-n1 niranjan-n1 niranjan-n1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@santhoshatdell @donatwork @alikdell @suryagupta4 @niranjan-n1