-
Notifications
You must be signed in to change notification settings - Fork 584
Doc: update DPA3 reference #4781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThis update enhances documentation by adding a bibliographic reference to the DPA-3 descriptor in class docstrings and replacing a placeholder with the actual reference in the DPA-3 model documentation. The README is also updated to accurately list both DPA-2 and DPA-3 as supported models. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Documentation
participant Codebase
User->>Documentation: Reads about DPA-3 model
Documentation->>User: Shows updated reference to arXiv paper
User->>Codebase: Reviews DPA-3 descriptor class
Codebase->>User: Presents docstring with bibliographic citation
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (29)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
README.md (1)
79-79: Fix grammatical number
Change “- The DPA-2 and DPA-3 model.” to plural for consistency:- - The DPA-2 and DPA-3 model. + - The DPA-2 and DPA-3 models.🧰 Tools
🪛 LanguageTool
[uncategorized] ~79-~79: The grammatical number of this noun doesn’t look right. Consider replacing it.
Context: ...and JAX backends. - The DPA-2 and DPA-3 model. - Plugin mechanisms for external model...(AI_EN_LECTOR_REPLACEMENT_NOUN_NUMBER)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
README.md(1 hunks)deepmd/dpmodel/descriptor/dpa3.py(2 hunks)deepmd/pd/model/descriptor/dpa3.py(2 hunks)deepmd/pt/model/descriptor/dpa3.py(2 hunks)doc/model/dpa3.md(1 hunks)
🧰 Additional context used
🪛 LanguageTool
README.md
[uncategorized] ~79-~79: The grammatical number of this noun doesn’t look right. Consider replacing it.
Context: ...and JAX backends. - The DPA-2 and DPA-3 model. - Plugin mechanisms for external model...
(AI_EN_LECTOR_REPLACEMENT_NOUN_NUMBER)
⏰ Context from checks skipped due to timeout of 90000ms (23)
- GitHub Check: Pass building C++
- GitHub Check: Test Python (6, 3.12)
- GitHub Check: Test Python (5, 3.9)
- GitHub Check: Test Python (5, 3.12)
- GitHub Check: Test Python (6, 3.9)
- GitHub Check: Test Python (1, 3.9)
- GitHub Check: Test Python (2, 3.9)
- GitHub Check: Test Python (3, 3.9)
- GitHub Check: Test Python (3, 3.12)
- GitHub Check: Test Python (1, 3.12)
- GitHub Check: Test Python (4, 3.9)
- GitHub Check: Test Python (4, 3.12)
- GitHub Check: Test Python (2, 3.12)
- GitHub Check: Build wheels for cp311-macosx_x86_64
- GitHub Check: Build wheels for cp310-manylinux_aarch64
- GitHub Check: Build wheels for cp311-manylinux_x86_64
- GitHub Check: Build wheels for cp311-win_amd64
- GitHub Check: Analyze (c-cpp)
- GitHub Check: Build wheels for cp311-manylinux_x86_64
- GitHub Check: Test C++ (true)
- GitHub Check: Test C++ (false)
- GitHub Check: Build C library (2.18, libdeepmd_c.tar.gz)
- GitHub Check: Build C library (2.14, >=2.5.0rc0,<2.15, libdeepmd_c_cu11.tar.gz)
🔇 Additional comments (7)
doc/model/dpa3.md (1)
14-14: Actual reference added
The placeholder text has been replaced with the arXiv link for the DPA-3 paper. Documentation update is correct and aligns with class docstrings.deepmd/pd/model/descriptor/dpa3.py (2)
66-66: Docstring reference marker added
Inserted[1]_marker in the class docstring to link to the bibliographic entry.
98-102: New References section
Bibliographic citation for Zhang et al. (2025) added under “References”.deepmd/pt/model/descriptor/dpa3.py (2)
66-66: Docstring reference marker added
Added[1]_marker in the descriptor docstring to point to the new reference.
98-102: New References section
Included full bibliographic entry for the DPA-3 paper.deepmd/dpmodel/descriptor/dpa3.py (2)
254-254: Docstring reference marker added
Updated the brief description to include[1]_linking to the reference.
286-290: New References section
Added the reference block citing the arXiv preprint by Zhang et al. (2025).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## devel #4781 +/- ##
==========================================
- Coverage 84.80% 84.80% -0.01%
==========================================
Files 698 698
Lines 67787 67787
Branches 3542 3543 +1
==========================================
- Hits 57486 57484 -2
Misses 9168 9168
- Partials 1133 1135 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary by CodeRabbit