Skip to content

Conversation

@njzjz
Copy link
Member

@njzjz njzjz commented May 13, 2025

Summary by CodeRabbit

  • Documentation
    • Updated all references and citations for the DeePMD-kit v3 paper from the previous arXiv preprint to the formal journal publication in the Journal of Chemical Theory and Computation, including updated DOI, volume, issue, and page numbers.
    • Enhanced citation entries with a detailed abstract and corrected bibliographic metadata.
    • Updated citation badges and links in documentation to reference the published article.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@ustc.edu.cn>
@njzjz njzjz requested review from Copilot and wanghan-iapcm and removed request for Copilot May 13, 2025 13:40
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates the citation details for DeePMD-kit v3 across multiple files. The changes include updating citation keys, journal names, volume/issue/page numbers, DOIs, and corresponding reference links in source code, documentation, and BibTeX entries.

  • Updated citation references in C++ source files (pair_deepspin.cpp and pair_deepmd.cpp)
  • Adjusted citation details in documentation files (credits.rst, README.md, and deepmd/utils/summary.py)
  • Revised BibTeX entry in CITATIONS.bib to reflect the published journal information

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
source/lmp/pair_deepspin.cpp Updated citation key and details in the source file
source/lmp/pair_deepmd.cpp Updated citation key and details in the source file
doc/credits.rst Revised citation key in the documentation
deepmd/utils/summary.py Updated citation text for the summary documentation
README.md Corrected citation text and updated DOI thumbnail links
CITATIONS.bib Revised BibTeX entry with journal information
Comments suppressed due to low confidence (6)

source/lmp/pair_deepspin.cpp:86

  • Ensure that the updated citation key and corresponding metadata (journal, volume, pages, DOI) correctly match the published details for DeePMD-kit v3.
@Article{Zeng_JChemTheoryComput_2025_v21_p4375,

source/lmp/pair_deepmd.cpp:86

  • Verify that the revised citation details in this file match those in pair_deepspin.cpp and reflect the correct published information.
@Article{Zeng_JChemTheoryComput_2025_v21_p4375,

doc/credits.rst:16

  • Double-check that the updated citation key is consistent throughout the documentation and accurately represents the new citation details.
Zeng_JChemTheoryComput_2025_v21_p4375

deepmd/utils/summary.py:45

  • Confirm that the citation text here correctly reflects the updated journal reference and is consistent with other citation updates.
Zeng et al, J. Chem. Theory Comput., 21, 4375-4385 (2025)

README.md:39

  • Ensure that the updated citation text and DOI badge/link additions accurately reflect the new publication details and are consistent with the other citation updates throughout the project.
Jinzhe Zeng, Duo Zhang, Anyang Peng, Xiangyu Zhang, Sensen He, Yan Wang, Xinzijian Liu, Hangrui Bi, Yifan Li, Chun Cai, Chengqian Zhang, Yiming Du, Jia-Xin Zhu, Pinghui Mo, Zhengtao Huang, Qiyu Zeng, Shaochen Shi, Xuejian Qin, Zhaoxi Yu, Chenxing Luo, Ye Ding, Yun-Pei Liu, Ruosong Shi, Zhenyu Wang, Sigbjørn Løland Bore, Junhan Chang, Zhe Deng, Zhaohan Ding, Siyuan Han, Wanrun Jiang, Guolin Ke, Zhaoqing Liu, Denghui Lu, Koki Muraoka, Hananeh Oliaei, Anurag Kumar Singh, Haohui Que, Weihong Xu, Zhangmancang Xu, Yong-Bin Zhuang, Jiayu Dai, Timothy J. Giese, Weile Jia, Ben Xu, Darrin M. York, Linfeng Zhang, Han Wang. "DeePMD-kit v3: A Multiple-Backend Framework for Machine Learning Potentials." J. Chem. Theory Comput. 21 (2025): 4375-4385.

CITATIONS.bib:43

  • Verify that the BibTeX entry now includes the correct journal, volume, number, pages, and DOI fields to ensure consistency with the revised citation format.
@article{Zeng_JChemTheoryComput_2025_v21_p4375,

@coderabbitai
Copy link
Contributor

coderabbitai bot commented May 13, 2025

📝 Walkthrough

"""

Walkthrough

The changes update all references and citations for the DeePMD-kit v3 paper from its previous arXiv preprint to the formal journal publication in the Journal of Chemical Theory and Computation. This includes updating citation metadata, BibTeX entries, citation strings, DOIs, and documentation references across code, documentation, and metadata files.

Changes

Files/Paths Change Summary
CITATIONS.bib Updated BibTeX entry for Zeng et al. 2025 from arXiv preprint to formal journal publication, including title, journal, volume, pages, DOI, and abstract.
README.md Updated citation and DOI for DeePMD-kit v3 from arXiv to journal publication; updated badges and links accordingly.
deepmd/utils/summary.py Updated citation string in SummaryPrinter to reference journal publication instead of arXiv preprint.
doc/credits.rst Updated citation key for Zeng 2025 from arXiv to journal publication.
source/lmp/pair_deepmd.cpp, source/lmp/pair_deepspin.cpp Updated static citation strings for DeePMD-kit v3 from arXiv to formal journal publication, including all relevant bibliographic metadata.

Sequence Diagram(s)

Not applicable: The changes are limited to citation and documentation updates, with no new features or control flow modifications.

Possibly related PRs

  • docs: add v3 paper citations #4619: Updates the same citation entries from the arXiv preprint to the journal publication, directly modifying similar files and citation strings.

Suggested labels

Docs, Python, LAMMPS

Suggested reviewers

  • wanghan-iapcm
  • iProzd
    """

Tip

⚡️ Faster reviews with caching
  • CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8a2247b and 399a19c.

📒 Files selected for processing (2)
  • source/lmp/pair_deepmd.cpp (2 hunks)
  • source/lmp/pair_deepspin.cpp (2 hunks)
✅ Files skipped from review due to trivial changes (1)
  • source/lmp/pair_deepspin.cpp
🚧 Files skipped from review as they are similar to previous changes (1)
  • source/lmp/pair_deepmd.cpp
⏰ Context from checks skipped due to timeout of 90000ms (30)
  • GitHub Check: Build wheels for cp310-manylinux_aarch64
  • GitHub Check: Test Python (6, 3.12)
  • GitHub Check: Build wheels for cp311-win_amd64
  • GitHub Check: Test Python (6, 3.9)
  • GitHub Check: Build wheels for cp311-macosx_arm64
  • GitHub Check: Test Python (5, 3.12)
  • GitHub Check: Build wheels for cp311-macosx_x86_64
  • GitHub Check: Test Python (5, 3.9)
  • GitHub Check: Build wheels for cp311-manylinux_x86_64
  • GitHub Check: Build wheels for cp311-manylinux_x86_64
  • GitHub Check: Test Python (4, 3.12)
  • GitHub Check: Analyze (python)
  • GitHub Check: Test Python (4, 3.9)
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: Test Python (3, 3.12)
  • GitHub Check: Analyze (c-cpp)
  • GitHub Check: Test Python (3, 3.9)
  • GitHub Check: Test C++ (false)
  • GitHub Check: Test Python (2, 3.12)
  • GitHub Check: Test C++ (true)
  • GitHub Check: Test Python (2, 3.9)
  • GitHub Check: Test Python (1, 3.12)
  • GitHub Check: Test Python (1, 3.9)
  • GitHub Check: Build C library (2.14, >=2.5.0rc0,<2.15, libdeepmd_c_cu11.tar.gz)
  • GitHub Check: Build C library (2.18, libdeepmd_c.tar.gz)
  • GitHub Check: Build C++ (clang, clang)
  • GitHub Check: Build C++ (rocm, rocm)
  • GitHub Check: Build C++ (cuda120, cuda)
  • GitHub Check: Build C++ (cuda, cuda)
  • GitHub Check: Build C++ (cpu, cpu)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Nitpick comments (2)
CITATIONS.bib (2)

62-67: Verify DOI & standardize issue/number field

  • Double-check that the DOI 10.1021/acs.jctc.5c00340 corresponds to volume 21(9), pages 4375–4385 of J. Chem. Theory Comput.
  • The entry uses number = 9, but other JCTC entries in this file use issue (e.g., lines 27, 272). Consider unifying on one field name for consistency.

68-86: Assess necessity of the abstract field
The multiline abstract field is comprehensive, but many BibTeX workflows ignore abstracts. If your tooling doesn’t utilize it, consider removing or relocating the abstract to reduce file size and improve maintainability. Otherwise, ensure your parser supports this multiline format.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8c6e2ea and 8a2247b.

📒 Files selected for processing (6)
  • CITATIONS.bib (2 hunks)
  • README.md (2 hunks)
  • deepmd/utils/summary.py (1 hunks)
  • doc/credits.rst (1 hunks)
  • source/lmp/pair_deepmd.cpp (2 hunks)
  • source/lmp/pair_deepspin.cpp (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (29)
  • GitHub Check: Test Python (6, 3.12)
  • GitHub Check: Test Python (6, 3.9)
  • GitHub Check: Test Python (5, 3.12)
  • GitHub Check: Test Python (5, 3.9)
  • GitHub Check: Test Python (4, 3.12)
  • GitHub Check: Build wheels for cp310-manylinux_aarch64
  • GitHub Check: Build wheels for cp311-win_amd64
  • GitHub Check: Test Python (4, 3.9)
  • GitHub Check: Test Python (3, 3.12)
  • GitHub Check: Build wheels for cp311-macosx_arm64
  • GitHub Check: Test Python (3, 3.9)
  • GitHub Check: Build C++ (clang, clang)
  • GitHub Check: Build wheels for cp311-macosx_x86_64
  • GitHub Check: Test Python (2, 3.12)
  • GitHub Check: Build C++ (rocm, rocm)
  • GitHub Check: Build wheels for cp311-manylinux_x86_64
  • GitHub Check: Test C++ (false)
  • GitHub Check: Analyze (python)
  • GitHub Check: Build wheels for cp311-manylinux_x86_64
  • GitHub Check: Build C++ (cuda120, cuda)
  • GitHub Check: Test Python (2, 3.9)
  • GitHub Check: Test C++ (true)
  • GitHub Check: Build C++ (cuda, cuda)
  • GitHub Check: Build C library (2.14, >=2.5.0rc0,<2.15, libdeepmd_c_cu11.tar.gz)
  • GitHub Check: Test Python (1, 3.12)
  • GitHub Check: Build C library (2.18, libdeepmd_c.tar.gz)
  • GitHub Check: Build C++ (cpu, cpu)
  • GitHub Check: Test Python (1, 3.9)
  • GitHub Check: Analyze (c-cpp)
🔇 Additional comments (5)
doc/credits.rst (1)

16-16: Updated citation key for v3 is correct
The entry Zeng_JChemTheoryComput_2025_v21_p4375 matches the new journal publication details and aligns with the rest of the bibliography.

deepmd/utils/summary.py (1)

45-45: SummaryPrinter citation updated correctly
The citation string now references “Zeng et al, J. Chem. Theory Comput., 21, 4375-4385 (2025)”, which matches the formal publication.

README.md (1)

39-41: README citation block for v3 paper is correct
The new list item, DOI badge, and link correctly reference the J. Chem. Theory Comput. publication for DeePMD-kit v3.

CITATIONS.bib (2)

43-57: Entry key & author list needs verification
Please confirm that the new entry key Zeng_JChemTheoryComput_2025_v21_p4375 follows the repository’s naming pattern and that the full author list exactly matches the published article (order, spelling, and diacritics). A mismatch here could cause citation errors or omissions downstream.


58-61: Title formatting looks good
The title is properly wrapped in double braces to preserve capitalization and includes “v3” to distinguish this version. No changes needed here.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@ustc.edu.cn>
@codecov
Copy link

codecov bot commented May 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.69%. Comparing base (8c6e2ea) to head (399a19c).
⚠️ Report is 77 commits behind head on devel.

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #4738   +/-   ##
=======================================
  Coverage   84.69%   84.69%           
=======================================
  Files         697      697           
  Lines       67473    67474    +1     
  Branches     3541     3541           
=======================================
+ Hits        57145    57146    +1     
- Misses       9196     9197    +1     
+ Partials     1132     1131    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wanghan-iapcm wanghan-iapcm enabled auto-merge May 14, 2025 03:03
@wanghan-iapcm wanghan-iapcm added this pull request to the merge queue May 14, 2025
Merged via the queue into deepmodeling:devel with commit 43e0288 May 14, 2025
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants