-
Notifications
You must be signed in to change notification settings - Fork 584
docs: add v3 paper citations #4619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@ustc.edu.cn>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This PR updates documentation by adding the v3 paper citations for DeePMD-kit. It provides an additional citation entry in the summary module and updates the README with the new v3 citation information.
- Added v3 paper citation reference in deepmd/utils/summary.py.
- Included the v3 paper citation in README.md along with a labeling update for the v2 paper.
- Updated links in README.md to reference the new v3 citation.
Reviewed Changes
| File | Description |
|---|---|
| deepmd/utils/summary.py | Added new v3 paper citation entry to the citation list. |
| README.md | Added new v3 citation information and reworded the v2 reference. |
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
README.md:80
- The v3 paper citation contains an incorrect DOI link; update it to the correct arXiv URL (e.g., https://arxiv.org/abs/2502.19161) to accurately reference the v3 paper.
See [our v3 paper](https://doi.org/5.0155600) for details of all features until v3.0.
📝 WalkthroughWalkthroughThis update integrates a new citation for the DeePMD-kit v3 article by Zeng et al. across multiple documentation and source files. The changes add a new article entry with complete bibliographic details in the bibliography file, update reference texts in the README, and append the new citation to the citation tuple in the summary utility. Additionally, modifications in several source files change the citation type from Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (20)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
CITATIONS.bib(1 hunks)README.md(2 hunks)deepmd/utils/summary.py(1 hunks)doc/credits.rst(1 hunks)source/lmp/pair_deepmd.cpp(2 hunks)source/lmp/pair_deepspin.cpp(2 hunks)
✅ Files skipped from review due to trivial changes (3)
- deepmd/utils/summary.py
- source/lmp/pair_deepmd.cpp
- source/lmp/pair_deepspin.cpp
⏰ Context from checks skipped due to timeout of 90000ms (20)
- GitHub Check: Build wheels for cp310-manylinux_aarch64
- GitHub Check: Build wheels for cp311-manylinux_x86_64
- GitHub Check: Build C++ (clang, clang)
- GitHub Check: Build wheels for cp311-win_amd64
- GitHub Check: Build wheels for cp311-macosx_arm64
- GitHub Check: Test Python (5, 3.9)
- GitHub Check: Test Python (3, 3.9)
- GitHub Check: Test Python (6, 3.9)
- GitHub Check: Test Python (6, 3.12)
- GitHub Check: Build wheels for cp311-macosx_x86_64
- GitHub Check: Build wheels for cp311-manylinux_x86_64
- GitHub Check: Test Python (5, 3.12)
- GitHub Check: Test Python (3, 3.12)
- GitHub Check: Test C++ (true)
- GitHub Check: Test Python (1, 3.12)
- GitHub Check: Test C++ (false)
- GitHub Check: Test Python (2, 3.12)
- GitHub Check: Test Python (2, 3.9)
- GitHub Check: Build C library (2.18, libdeepmd_c.tar.gz)
- GitHub Check: Test Python (1, 3.9)
🔇 Additional comments (4)
doc/credits.rst (1)
16-16: Citation correctly added for v3 paper.The new bibliography entry for the v3 paper has been properly added to the document.
CITATIONS.bib (1)
43-66: Citation entry properly formatted and complete.The new citation entry for the DeePMD-kit v3 paper is well-structured with all required fields (author, title, journal, year, pages, DOI) and follows the same formatting style as other entries in the file.
README.md (2)
39-39: DeePMD-kit v3 citation correctly added.The citation for the v3 paper has been properly added with complete author list and arXiv reference.
72-72: Reference text updated appropriately.Changed "our latest paper" to "our v2 paper" which is more specific and future-proof.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #4619 +/- ##
==========================================
- Coverage 84.58% 84.58% -0.01%
==========================================
Files 680 680
Lines 64544 64543 -1
Branches 3538 3539 +1
==========================================
- Hits 54596 54595 -1
Misses 8807 8807
Partials 1141 1141 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: Jinzhe Zeng <njzjz@qq.com>
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Documentation** - Added a new citation for the "DeePMD-kit v3" article in various documentation files. - Clarified references to distinguish between the "v2" and "v3" publications. - Enhanced bibliography and credits details for improved clarity. - **Chores** - Revised citation formatting across the package to reflect formal publication standards. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Jinzhe Zeng <jinzhe.zeng@ustc.edu.cn> Signed-off-by: Jinzhe Zeng <njzjz@qq.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> (cherry picked from commit 918d4de)
Summary by CodeRabbit
Documentation
Chores