Backport 'Fix order when filtering Meetings' to v0.26#9751
Merged
andreslucena merged 5 commits intorelease/0.26-stablefrom Sep 12, 2022
Merged
Conversation
* Change date meetings filters checkboxes to radio buttons * Fix default upcoming filter on meetings' controller * Order filtered meetings by start_time * Use Faker::Date in meetings' seeds * Convert let definitions to one line blocks * Fix typo * Add default filter specs for Upcoming meetings * Add specs for 'date filters' on meetings * Reintroduces the 'All' filter for meetings dates * Remove uneceessary instance variable Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi> * Fix for 500 errors on static maps * Preserve the currently selected per_page value with filter forms * Fix the broken specs due to changes in the per_page configuration * Do not use concat in helpers that are used in cells * Rubocop Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>
Contributor
Author
|
Notes for reviewer:
|
andreslucena
approved these changes
Sep 12, 2022
Member
andreslucena
left a comment
There was a problem hiding this comment.
I've done some quick frontend check for this one just to be extra sure. Seems like everything is as expected.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Backport #9683 to v0.26