Add malformed file errors when CSV reading fails#9613
Merged
andreslucena merged 8 commits intodecidim:developfrom Oct 6, 2022
Merged
Add malformed file errors when CSV reading fails#9613andreslucena merged 8 commits intodecidim:developfrom
andreslucena merged 8 commits intodecidim:developfrom
Conversation
Member
|
Great fix! I can confirm that's working on those forms. I found out that I can reproduce the 500 error on Admin -> Participants -> Organization's census ( |
andreslucena
requested changes
Sep 23, 2022
Member
andreslucena
left a comment
There was a problem hiding this comment.
I've left a comment with a minor change, can you check it out whenever you have time? Thanks
Member
|
The failing spec should be green already, as it's fixed with #9863. Can you merge with develop @ahukkanen 🙏🏽? Thanks |
Member
|
@ahukkanen can you check my last comment 🙏🏽? |
Contributor
Author
|
Done @andreslucena |
Contributor
Author
|
The broken core and proposals specs are unrelated. They will be fixed by #9877. |
andreslucena
approved these changes
Oct 5, 2022
Member
andreslucena
left a comment
There was a problem hiding this comment.
LGTM 👍🏽
I'll wait for @fblupi review before merging this. Let me know when this is done.
eliegaboriau
pushed a commit
to eliegaboriau/decidim
that referenced
this pull request
Oct 25, 2022
* Add malformed file errors when CSV reading fails * Exclude the introduced ISO 8859-1 encoded file from the i18n scan * Fix the formatting server error for the CSV census form
This was referenced Oct 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
At the admin panel when we upload specific CSV files and they are malformed (e.g. wrong encoding), the system will just show a general HTTP 500 error for the user which can be confusing.
This adds proper error messages in these situations.
📌 Related Issues
Testing
📷 Screenshots