Skip to content

Fix displaying blocked users in account follow pages#9164

Merged
ahukkanen merged 11 commits intodecidim:developfrom
eliegaboriau:fix/blocked_users_in_follow
Apr 29, 2022
Merged

Fix displaying blocked users in account follow pages#9164
ahukkanen merged 11 commits intodecidim:developfrom
eliegaboriau:fix/blocked_users_in_follow

Conversation

@eliegaboriau
Copy link
Copy Markdown
Contributor

@eliegaboriau eliegaboriau commented Apr 13, 2022 •
edited
Loading

🎩 What? Why?

Remove blocked users from being displaying in the follow/following section

📌 Related Issues

Link your PR to an issue

Testing

Block a user who is following somebody
Check the followers of this somebody

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

♥️ Thank you!

@eliegaboriau eliegaboriau marked this pull request as ready for review April 14, 2022 09:30
@eliegaboriau eliegaboriau marked this pull request as draft April 14, 2022 12:19
Quentinchampenois
Quentinchampenois suggested changes Apr 14, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@Quentinchampenois Quentinchampenois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
Just a little change request, otherwise it seems good to me !

Quentinchampenois
Quentinchampenois approved these changes Apr 15, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@Quentinchampenois Quentinchampenois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems good to me, thanks !

I let Decidim's reviewers take a look

@Quentinchampenois
Copy link
Copy Markdown
Contributor

Quentinchampenois commented Apr 15, 2022

I just noticed the failing CI on Comments, it seems to happen on others PRs, is this a known flaky test or maybe the branch should be rebased ?

@eliegaboriau eliegaboriau marked this pull request as ready for review April 15, 2022 08:16
@eliegaboriau
Copy link
Copy Markdown
Contributor Author

eliegaboriau commented Apr 15, 2022

I just noticed the failing CI on Comments, it seems to happen on others PRs, is this a known flaky test or maybe the branch should be rebased ?

It's not failing locally so i don't think it's from my changes

@andreslucena andreslucena changed the title fix displaying block users Fix displaying blocked users in account follow pages Apr 19, 2022
@andreslucena andreslucena added module: core type: fix PRs that implement a fix for a bug labels Apr 19, 2022
@andreslucena
Copy link
Copy Markdown
Member

andreslucena commented Apr 19, 2022

I just noticed the failing CI on Comments, it seems to happen on others PRs, is this a known flaky test or maybe the branch should be rebased ?

Don't worry, it's a flaky unrelated to this PR, it comes from #9090

@andreslucena andreslucena mentioned this pull request Apr 19, 2022
Merged
@ahukkanen ahukkanen merged commit 6f239ad into decidim:develop Apr 29, 2022
andreslucena pushed a commit that referenced this pull request May 6, 2022
@eliegaboriau @andreslucena
Fix displaying blocked users in account follow pages (#9164)
b91ffc0 
* fix displaying block users

* able to render ressource

* fix gemfile test

* fix gemfile test

* fix gemfile test

* refactor change

* refactor change

* linter

* add unit test

* linter

* add trait
@andreslucena andreslucena mentioned this pull request May 6, 2022
Merged
ahukkanen pushed a commit that referenced this pull request May 10, 2022
@andreslucena @eliegaboriau
Fix displaying blocked users in account follow pages (#9164) (#9255)
7583904 
* fix displaying block users

* able to render ressource

* fix gemfile test

* fix gemfile test

* fix gemfile test

* refactor change

* refactor change

* linter

* add unit test

* linter

* add trait

Co-authored-by: eliegaboriau <93646702+eliegaboriau@users.noreply.github.com>
@verarojman verarojman mentioned this pull request Jul 14, 2022
Merged
12 tasks
@microstudi microstudi mentioned this pull request Jul 28, 2022
Closed
@microstudi microstudi mentioned this pull request Aug 26, 2022
Closed
12 tasks
@microstudi microstudi mentioned this pull request Sep 13, 2022
Merged
@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahukkanen ahukkanen ahukkanen approved these changes

+1 more reviewer

@Quentinchampenois Quentinchampenois Quentinchampenois approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

module: core type: fix PRs that implement a fix for a bug

Projects

None yet

Milestone

0.27.0

Development

Successfully merging this pull request may close these issues.

Blocked users appear in public profile tabs (follows and followers)

5 participants

@eliegaboriau @Quentinchampenois @andreslucena @ahukkanen @alecslupu