Skip to content

Fix the HTML diff mode accessibility#8915

Merged
andreslucena merged 1 commit intodecidim:developfrom
mainio:fix/html-diff-mode-dropdown
Feb 25, 2022
Merged

Fix the HTML diff mode accessibility#8915
andreslucena merged 1 commit intodecidim:developfrom
mainio:fix/html-diff-mode-dropdown

Conversation

@ahukkanen
Copy link
Copy Markdown
Contributor

@ahukkanen ahukkanen commented Feb 24, 2022

🎩 What? Why?

This applies the same accessibility fixes as #8879 and #8912 combined to the HTML diff mode selector.

When implementing #8912, I added some accessibility tests to the diff mode pages and noticed that they have duplicate IDs on them. The issue is that the diff mode selector and the HTML mode selector use the same IDs.

This fixes the issue by applying unique IDs to the HTML diff mode selector while also fixing the same accessibility issues with the HTML diff mode selector.

📌 Related Issues

Link your PR to an issue

Testing

  • Enable HTML editor for the participants from the settings
  • Check the accessibility tool issues on the diff mode page (e.g. a version page)

📋 Checklist

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Two diff modes on the version page

@andreslucena andreslucena added module: core team: accessibility type: fix PRs that implement a fix for a bug labels Feb 25, 2022
@andreslucena andreslucena merged commit 9a6cda1 into decidim:develop Feb 25, 2022
@andreslucena
Copy link
Copy Markdown
Member

Can you please backport to v0.26-stable 🙏🏽? Thanks

@ahukkanen ahukkanen deleted the fix/html-diff-mode-dropdown branch February 25, 2022 07:55
ahukkanen added a commit to mainio/decidim that referenced this pull request Mar 2, 2022
@ahukkanen
Copy link
Copy Markdown
Contributor Author

Backport at #8950.

@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: core team: accessibility type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants