Fix the HTML diff mode accessibility#8915
Merged
andreslucena merged 1 commit intodecidim:developfrom Feb 25, 2022
Merged
Conversation
This was referenced Feb 24, 2022
andreslucena
approved these changes
Feb 25, 2022
Member
|
Can you please backport to v0.26-stable 🙏🏽? Thanks |
Contributor
Author
|
Backport at #8950. |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This applies the same accessibility fixes as #8879 and #8912 combined to the HTML diff mode selector.
When implementing #8912, I added some accessibility tests to the diff mode pages and noticed that they have duplicate IDs on them. The issue is that the diff mode selector and the HTML mode selector use the same IDs.
This fixes the issue by applying unique IDs to the HTML diff mode selector while also fixing the same accessibility issues with the HTML diff mode selector.
📌 Related Issues
Link your PR to an issue
Testing
📋 Checklist
docs/.📷 Screenshots