Fix diff mode selector accessibility#8879
Merged
andreslucena merged 2 commits intodecidim:developfrom Feb 23, 2022
Merged
Conversation
andreslucena
approved these changes
Feb 22, 2022
Member
andreslucena
left a comment
There was a problem hiding this comment.
Thanks for the time on this one and the video 👏🏽 👏🏽
Member
|
Can you please backport to v0.26-stable 🙏🏽? Thanks |
Contributor
Author
|
Backport at #8900. |
This was referenced Feb 24, 2022
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Currently users using keyboard commands or speech voice control cannot focus the diff mode selector dropdown. This PR fixes that.
There are also other accessibility issues with this element:
WCAG 2.2 / 2.1.1 Keyboard (Level A)
WCAG 2.2 / 4.1.2 Name, Role, Value (Level A)
https://www.w3.org/TR/WCAG22/#keyboard
https://www.w3.org/TR/WCAG22/#name-role-value
https://www.w3.org/WAI/WCAG22/Understanding/keyboard.html
https://www.w3.org/WAI/WCAG22/Understanding/name-role-value.html
Testing
Ask a user using either keyboard controls or speech control to test the diff mode dropdown.
📋 Checklist
docs/.📷 Screenshots
decidim-diff-mode.mp4