Skip to content

DRY GitHub workflows with composite actions#8677

Merged
andreslucena merged 3 commits intodecidim:developfrom
i-need-another-coffee:fix/workflow-composite
Jan 4, 2022
Merged

DRY GitHub workflows with composite actions#8677
andreslucena merged 3 commits intodecidim:developfrom
i-need-another-coffee:fix/workflow-composite

Conversation

@alecslupu
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu commented Jan 3, 2022

🎩 What? Why?

This PR make some tests with GH Actions to improve workflows performance and maintainability. This is another attempt on the work done by @leio10 in #8324.

📌 Related Issues

Link your PR to an issue

♥️ Thank you!

@alecslupu alecslupu force-pushed the fix/workflow-composite branch from 98fe5a4 to 9f80103 Compare January 3, 2022 13:27
@alecslupu alecslupu changed the title Fix/workflow composite Adding Github composite actions Jan 3, 2022
@alecslupu alecslupu marked this pull request as ready for review January 3, 2022 14:09
@alecslupu alecslupu force-pushed the fix/workflow-composite branch from 9f80103 to 183d100 Compare January 3, 2022 14:48
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you merge/rebase with develop so it's easier to see the changes? Thanks

@alecslupu alecslupu force-pushed the fix/workflow-composite branch from 183d100 to 6a49065 Compare January 4, 2022 08:11
@alecslupu alecslupu requested a review from andreslucena January 4, 2022 09:53
@andreslucena andreslucena changed the title Adding Github composite actions DRY GitHub workflows with composite actions Jan 4, 2022
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
😍

Best PR of 2021 so far! Thanks for taking care of this

@andreslucena andreslucena merged commit 0d508a8 into decidim:develop Jan 4, 2022
@alecslupu alecslupu deleted the fix/workflow-composite branch January 4, 2022 10:43
@andreslucena andreslucena added type: internal PRs that aren't necessary to add to the CHANGELOG for implementers and removed target: developer-experience labels Jan 10, 2022
@alecslupu alecslupu added this to the 0.26.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: internal PRs that aren't necessary to add to the CHANGELOG for implementers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants