Skip to content

Test GH Actions composite actions#8324

Closed
leio10 wants to merge 2 commits intodevelopfrom
chore/test-composite-actions
Closed

Test GH Actions composite actions#8324
leio10 wants to merge 2 commits intodevelopfrom
chore/test-composite-actions

Conversation

@leio10
Copy link
Copy Markdown
Contributor

@leio10 leio10 commented Sep 13, 2021

🎩 What? Why?

This PR make some tests with GH Actions to improve workflows performance and maintainability.

📌 Related Issues

Link your PR to an issue

  • Related to #?
  • Fixes #?

Testing

Describe the best way to test or validate your PR.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

@leio10 leio10 marked this pull request as draft September 13, 2021 10:28
@leio10 leio10 force-pushed the chore/test-composite-actions branch from b0ddb3b to 2b08657 Compare September 13, 2021 10:30
@leio10 leio10 closed this Sep 13, 2021
@leio10 leio10 force-pushed the chore/test-composite-actions branch from 2b08657 to 6c59412 Compare September 13, 2021 10:38
@leio10 leio10 reopened this Sep 13, 2021
@leio10 leio10 force-pushed the chore/test-composite-actions branch from 358c081 to c488d9f Compare September 13, 2021 10:54
@andreslucena
Copy link
Copy Markdown
Member

andreslucena commented Sep 14, 2021

I wanted this feature from day 1 of using GH Actions! 🎉

baby-yoda

@andreslucena
Copy link
Copy Markdown
Member

andreslucena commented Oct 26, 2021

@leio10 are you planning in retaking this issue or can we close it?

As far as I see there are three kind of errors:

  1. Required property is missing: shell

We need to explicitly add shell: bash

  1. Unexpected value 'if'

Seems like currently isn't supported in composite actions, although there could be a workaround involving moving this check to the script (it's all in the same issue, actions/runner#834). We'd need to study if this is feasible in our case.

  1. Unrecognized named-value: 'secrets'

There's a workaround for this one too.

@leio10
Copy link
Copy Markdown
Contributor Author

leio10 commented Nov 2, 2021

Closing this, as it is not working as expected.

@leio10 leio10 closed this Nov 2, 2021
@andreslucena andreslucena mentioned this pull request Jan 3, 2022
Merged
@alecslupu alecslupu mentioned this pull request Jan 3, 2022
Merged
@andreslucena andreslucena deleted the chore/test-composite-actions branch March 4, 2022 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

target: developer-experience

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@leio10 @andreslucena