Skip to content

Split the workflows files for CI#8675

Merged
andreslucena merged 3 commits intodecidim:developfrom
i-need-another-coffee:fix/workflow-split
Jan 4, 2022
Merged

Split the workflows files for CI#8675
andreslucena merged 3 commits intodecidim:developfrom
i-need-another-coffee:fix/workflow-split

Conversation

@alecslupu
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu commented Jan 3, 2022

🎩 What? Why?

This PR does not add any product functionality. It only splits the actions to reduce the amount of time spent building the application, with attempt to keep it under or around 30 minutes.

♥️ Thank you!

@alecslupu alecslupu requested a review from roxanaopr January 3, 2022 08:38
@alecslupu alecslupu marked this pull request as ready for review January 3, 2022 08:39
@andreslucena
Copy link
Copy Markdown
Member

Before splitting even more the workflow files, I'd love to retake on the composite approach on workflows. Right now, there's a lot of duplication that maybe could be avoided. See #8324

@alecslupu
Copy link
Copy Markdown
Contributor Author

Before splitting even more the workflow files, I'd love to retake on the composite approach on workflows. Right now, there's a lot of duplication that maybe could be avoided. See #8324

I would merge it, now, as the work is already done, and take another swing to the composite.

@alecslupu
Copy link
Copy Markdown
Contributor Author

@andreslucena , the composite actions are tackled in #8677 , which is created from this branch

Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 really small changes.

Also, while seeing the names I found that we have a typo in "Proposals (system public2)" - it should be "(system public 2)" - can you fix that?

Comment thread .github/workflows/ci_admin.yml
Comment thread .github/workflows/ci_initiatives.yml
@andreslucena
Copy link
Copy Markdown
Member

I compared times with other current PRs and I see that with some of the workflows we win from 4 to 10 minutes, and it's always a win in time, so great contribution 😄

@andreslucena andreslucena changed the title Split the workflows files Split the workflows files for CI Jan 4, 2022
@andreslucena andreslucena merged commit 0be7eda into decidim:develop Jan 4, 2022
@alecslupu alecslupu deleted the fix/workflow-split branch January 4, 2022 08:02
@andreslucena andreslucena added type: internal PRs that aren't necessary to add to the CHANGELOG for implementers and removed target: developer-experience labels Jan 10, 2022
@alecslupu alecslupu added this to the 0.26.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: internal PRs that aren't necessary to add to the CHANGELOG for implementers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants