Don't start poll meetings component when DOM elements are not present#8676
Merged
andreslucena merged 1 commit intodevelopfrom Jan 3, 2022
Merged
Don't start poll meetings component when DOM elements are not present#8676andreslucena merged 1 commit intodevelopfrom
andreslucena merged 1 commit intodevelopfrom
Conversation
Member
andreslucena
pushed a commit
that referenced
this pull request
Jan 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR fixes the PollComponent of Meetings module, which was being called in the DOM even when the container object didn't exist. With this PR this behaviour is prevented and the JS error is removed.
📌 Related Issues
Testing
Steps to reproduce the behavior:
Besides that, in the specs there was a warning showing the JS error:
This warning has disappeared too. Because this was a JS error that didn't prevent the functionality to work I haven't added a test.
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots
Please add screenshots of the changes you're proposing
