Skip to content

Remove truncato dependency#8507

Merged
andreslucena merged 33 commits intodecidim:developfrom
mainio:refactor/truncation
Dec 20, 2021
Merged

Remove truncato dependency#8507
andreslucena merged 33 commits intodecidim:developfrom
mainio:refactor/truncation

Conversation

@lahdeero
Copy link
Copy Markdown
Contributor

@lahdeero lahdeero commented Nov 8, 2021 •
edited
Loading

🎩 What? Why?

Remove truncato gem and add service which should do same thing. Reasoning same as in #8453.

📌 Related Issues

#8453
#7234

Testing

html_truncate is used in many places, for example:

  1. Homepage last activity feed truncates proposal bodies.
  2. Short description of process is truncated at /processes
  3. Blog index view
  4. Proposals map

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

📷 Screenshots

image

♥️ Thank you!

@lahdeero lahdeero force-pushed the refactor/truncation branch from 5de8344 to 25dc229 Compare November 8, 2021 15:49
@andreslucena andreslucena mentioned this pull request Nov 12, 2021
Closed
6 tasks
ahukkanen
ahukkanen requested changes Nov 24, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@ahukkanen ahukkanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good and simple!

I've left some refactoring requests after going through the code.

@ahukkanen
Copy link
Copy Markdown
Contributor

ahukkanen commented Dec 14, 2021

@andreslucena This is ready for review.

andreslucena
andreslucena requested changes Dec 17, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two really minor corrections

Eero Lahdenperä and others added 2 commits December 17, 2021 11:03
@andreslucena
Update decidim-core/spec/services/decidim/html_truncation_spec.rb
fa96802 
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
@andreslucena
Update decidim-core/spec/services/decidim/html_truncation_spec.rb
9e9aaee 
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
@ahukkanen
Copy link
Copy Markdown
Contributor

ahukkanen commented Dec 17, 2021

@andreslucena The requested changes are now done.

@andreslucena andreslucena merged commit 03b6145 into decidim:develop Dec 20, 2021
@andreslucena
Copy link
Copy Markdown
Member

andreslucena commented Dec 20, 2021

The requested changes are now done.

Awesome, merged!! 🚀

@ahukkanen ahukkanen deleted the refactor/truncation branch December 20, 2021 09:55
@andreslucena andreslucena linked an issue Dec 21, 2021 that may be closed by this pull request
Replace libraries (gems) with small communities with alternatives #8516
Closed
6 tasks
@andreslucena andreslucena added type: internal PRs that aren't necessary to add to the CHANGELOG for implementers and removed target: developer-experience labels Jan 10, 2022
@andreslucena andreslucena mentioned this pull request May 13, 2022
Closed
puria added a commit to puria/decidim that referenced this pull request Jun 8, 2022
@puria
Backport of decidim#8507
7daa44d
@alecslupu alecslupu added this to the 0.26.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahukkanen ahukkanen ahukkanen requested changes

@andreslucena andreslucena andreslucena approved these changes

Assignees

No one assigned

Labels

in-review type: internal PRs that aren't necessary to add to the CHANGELOG for implementers

Projects

None yet

Milestone

0.26.0

Development

Successfully merging this pull request may close these issues.

Replace libraries (gems) with small communities with alternatives

4 participants

@lahdeero @ahukkanen @andreslucena @alecslupu