Skip to content

Remove anchored dependency#8453

Merged
leio10 merged 5 commits intodecidim:developfrom
mainio:refactor/link_renderer
Nov 4, 2021
Merged

Remove anchored dependency#8453
leio10 merged 5 commits intodecidim:developfrom
mainio:refactor/link_renderer

Conversation

@lahdeero
Copy link
Copy Markdown
Contributor

@lahdeero lahdeero commented Nov 1, 2021

🎩 What? Why?

Remove anchored gem dependency.

Testing

  1. Create new proposal and add url to the body. (e.g. https://meta.decidim.org/)
  2. In preview view you can see that the url is a link.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

♥️ Thank you!

@leio10
Copy link
Copy Markdown
Contributor

leio10 commented Nov 2, 2021

Hi @lahdeero, can you briefly expose the reasons for removing the anchored gem? Thanks!

@lahdeero
Copy link
Copy Markdown
Contributor Author

lahdeero commented Nov 2, 2021

@leio10 We had meeting with @andreslucena and @ahukkanen where we agreed to remove small community gem dependencies, including: system_test_html_screenshots, anchored, nobspw, truncato, etherpad-lite and searchlight/spotlight.

@ahukkanen
Copy link
Copy Markdown
Contributor

@leio10 Also to add, this is somewhat related to this discussion: #7234

@andreslucena wants to reduce the bus factor risk on the Decidim codebase which is why we are doing this. Or to avoid the discontinuation that has happened e.g. with Virtus. We will be also addressing the Virtus gem discontinuation issue in the near future.

So, we have audited all Decidim gem dependencies and identified some gems that either (a) have a low number of contributors or (b) have been stagnating, so we are trying to make Decidim less dependent on those gems + the dependency is used by the participant-facing application (and not e.g. the test framework only). The audit only considered these factors of each gem.

Regarding the searchlight/spotlight gem, it's unnecessary because there is already Ransack that can do the same.

So we are basically paying back either current or future technical debt with these PRs.

http://example.com/引き割り.html
http://example.com/%E5%BC%95%E3%81%8D%E5%89%B2%E3%82%8A.html
https://nörttilive.fi
http://www.sinara.technology/about/
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we shouldn't advertise any particular services/companies here, so these could be changed:

@leio10 leio10 merged commit 2e42252 into decidim:develop Nov 4, 2021
@lahdeero lahdeero deleted the refactor/link_renderer branch November 5, 2021 09:29
@andreslucena andreslucena linked an issue Nov 12, 2021 that may be closed by this pull request
6 tasks
@andreslucena
Copy link
Copy Markdown
Member

Hi @lahdeero, can you briefly expose the reasons for removing the anchored gem? Thanks!

Sorry guys that I didn't have time to create the issue 😅
I've created it here, explaining also the reasoning #8516

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace libraries (gems) with small communities with alternatives

5 participants