Fix CSS validation tests caused by a bug on the validation service#8322
Merged
Fix CSS validation tests caused by a bug on the validation service#8322
Conversation
12 tasks
leio10
added a commit
that referenced
this pull request
Sep 13, 2021
…8322) * fix: remove use of css variable, as validation service fails * refactor: remove unnecesary fix
This was referenced Sep 13, 2021
Quentinchampenois
pushed a commit
to Quentinchampenois/decidim
that referenced
this pull request
Sep 14, 2021
…ecidim#8322) * fix: remove use of css variable, as validation service fails * refactor: remove unnecesary fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
The EmojiPicker adds some CSS styles to the HTML that are not well handled by the CSS validation service. This PR changes those lines until the problem is solved.
This PR also removes a related fix that is not needed anymore.
📌 Related Issues
Testing
Describe the best way to test or validate your PR.
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots
Please add screenshots of the changes you're proposing
