Skip to content

Fix CSS validation tests caused by a bug on the validation service#8322

Merged
leio10 merged 2 commits intodevelopfrom
fix/bypass-css-validation-bug
Sep 13, 2021
Merged

Fix CSS validation tests caused by a bug on the validation service#8322
leio10 merged 2 commits intodevelopfrom
fix/bypass-css-validation-bug

Conversation

@leio10
Copy link
Copy Markdown
Contributor

@leio10 leio10 commented Sep 13, 2021

🎩 What? Why?

The EmojiPicker adds some CSS styles to the HTML that are not well handled by the CSS validation service. This PR changes those lines until the problem is solved.

This PR also removes a related fix that is not needed anymore.

📌 Related Issues

Testing

Describe the best way to test or validate your PR.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

@leio10 leio10 added target: developer-experience type: fix PRs that implement a fix for a bug labels Sep 13, 2021
@leio10 leio10 merged commit 6c59412 into develop Sep 13, 2021
@leio10 leio10 deleted the fix/bypass-css-validation-bug branch September 13, 2021 10:17
leio10 added a commit that referenced this pull request Sep 13, 2021
…8322)

* fix: remove use of css variable, as validation service fails

* refactor: remove unnecesary fix
Quentinchampenois pushed a commit to Quentinchampenois/decidim that referenced this pull request Sep 14, 2021
…ecidim#8322)

* fix: remove use of css variable, as validation service fails

* refactor: remove unnecesary fix
@andreslucena andreslucena added type: bug type: internal PRs that aren't necessary to add to the CHANGELOG for implementers and removed target: developer-experience type: bug type: fix PRs that implement a fix for a bug labels Jan 10, 2022
@alecslupu alecslupu added this to the 0.26.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: internal PRs that aren't necessary to add to the CHANGELOG for implementers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants