Skip to content

Fix editor paste#7241

Merged
mrcasals merged 2 commits intodecidim:developfrom
mainio:fix/editor_paste
Jan 28, 2021
Merged

Fix editor paste#7241
mrcasals merged 2 commits intodecidim:developfrom
mainio:fix/editor_paste

Conversation

@lahdeero
Copy link
Copy Markdown
Contributor

@lahdeero lahdeero commented Jan 28, 2021

🎩 What? Why?

#7070 broke pasting into the editor. This fixes paste and another bug where user was unable to delete paragraph change by pressing backspace.

📌 Related Issues

#7180

Testing

  1. Go to /admin/organization/edit
  2. Copy any text, for instance "Hello world"
  3. Paste it in "Admin terms of use body"

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

♥️ Thank you!

@lahdeero lahdeero changed the title Fix/editor paste Fix editor paste Jan 28, 2021
mrcasals
mrcasals approved these changes Jan 28, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@mrcasals mrcasals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you so much, @lahdeero!

decidim-admin/spec/system/admin_manages_organization_spec.rb
end

it "deletes paragraph changes pressing backspace" do
find('div[contenteditable="true"].ql-editor').send_keys "ef", [:enter], "gh", [:backspace], [:backspace], [:backspace], [:backspace]
Copy link
Copy Markdown
Contributor

@mrcasals mrcasals Jan 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!!

@mrcasals mrcasals merged commit 809bbd8 into decidim:develop Jan 28, 2021
@mrcasals mrcasals mentioned this pull request Jan 28, 2021
Closed
andreslucena pushed a commit that referenced this pull request Feb 3, 2021
@lahdeero @andreslucena
Fix editor paste (#7241)
ed0b0e2
@ahukkanen ahukkanen deleted the fix/editor_paste branch February 16, 2021 09:28
@mrcasals mrcasals added module: admin module: core type: fix PRs that implement a fix for a bug labels Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mrcasals mrcasals mrcasals approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

module: admin module: core type: fix PRs that implement a fix for a bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lahdeero @mrcasals