Skip to content

Fix editor linebreak module#7070

Merged
oriolgual merged 10 commits intodecidim:developfrom
mainio:fix/editor-ctrl-z
Jan 14, 2021
Merged

Fix editor linebreak module#7070
oriolgual merged 10 commits intodecidim:developfrom
mainio:fix/editor-ctrl-z

Conversation

@lahdeero
Copy link
Copy Markdown
Contributor

@lahdeero lahdeero commented Dec 31, 2020

🎩 What? Why?

Found some bugs in linebreak module, biggest one was that quill was unable to calculate history differences (breaking control+z and control+shift+z). So I had to overwrite most of methods in history class. Also fixed couple minor bugs where enter and backspace didn't work as expected.

Testing

Admin dashboard -> Settings -> Admin terms of use body -> Write something and press ctrl+z and then ctrl+shift+z.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

image

♥️ Thank you!

@lahdeero lahdeero changed the title Fix/editor linebreak module bugfixes Fix/editor linebreak module Jan 7, 2021
@oriolgual oriolgual merged commit c17698e into decidim:develop Jan 14, 2021
@ahukkanen ahukkanen deleted the fix/editor-ctrl-z branch January 15, 2021 11:53
@lahdeero lahdeero mentioned this pull request Jan 28, 2021
12 tasks
@mrcasals mrcasals changed the title Fix/editor linebreak module Fix editor linebreak module Feb 26, 2021
@mrcasals mrcasals added module: admin module: core type: fix PRs that implement a fix for a bug labels Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: admin module: core type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants