Create Votings participatory space#7145
Merged
Conversation
decidim-elections/app/permissions/decidim/votings/admin/permissions.rb
Outdated
Show resolved
Hide resolved
da43e2a to
a0229fb
Compare
a57f79b to
4c4c031
Compare
628e078 to
8c72da8
Compare
slickepinne
previously approved these changes
Jan 18, 2021
decidim-elections/app/controllers/decidim/votings/admin/votings_controller.rb
Outdated
Show resolved
Hide resolved
… admin_log presenter and organization votings query
c065398 to
beaf8ae
Compare
Contributor
|
@decidim/mantainers this has been approved by product 🎉 |
mrcasals
approved these changes
Jan 22, 2021
| validates :end_time, presence: true, date: { after: :start_time } | ||
| validates :banner_image, passthru: { to: Decidim::Votings::Voting } | ||
| validates :introductory_image, passthru: { to: Decidim::Votings::Voting } | ||
| # validate :notify_missing_attachment_if_errored |
Contributor
Contributor
There was a problem hiding this comment.
Thank you @mrcasals! Yes, it is already handled in an upcoming PR 👍
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR creates a new participatory space named
Votings(inside thedecidim-electionsmodule)Admin users can:
A voting is:
NB: some portions of code are commented out and will be addressed in an upcoming PR (#7160 - Manage Votings)
📌 Related Issues
Testing
Describe the best way to test or validate your PR.
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots