Skip to content

Manage Votings#7160

Merged
mrcasals merged 55 commits intodevelopfrom
feat/manage-votings
Jan 25, 2021
Merged

Manage Votings#7160
mrcasals merged 55 commits intodevelopfrom
feat/manage-votings

Conversation

@orlera
Copy link
Copy Markdown
Contributor

@orlera orlera commented Jan 15, 2021 •
edited
Loading

🎩 What? Why?

A follow up to #7145 that allows managing the Votings from the admin panel and creates the public pages for them (index and show).

In the specific:

  • From the admin panel, an admin can:
    • update a Voting;
    • publish/unpublish a Voting and see the action logged in the admin log;
    • access a Voting's public page;
  • From the public area, a normal/anonymous user can:
    • access the Votings list from the menu when there is at least a published Voting;
    • filter and sort the Votings;
    • search for a Voting by title or description from the global search;
    • access a stripped Voting's public page.

manage

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

♥️ Thank you!

@orlera orlera changed the base branch from develop to feat/add_votings_space January 15, 2021 10:09
qlty-cloud-legacy[bot]
qlty-cloud-legacy bot reviewed Jan 15, 2021
View reviewed changes
@orlera orlera force-pushed the feat/manage-votings branch 2 times, most recently from 0981e77 to a2f7374 Compare January 15, 2021 16:21
@orlera orlera linked an issue Jan 15, 2021 that may be closed by this pull request
Manage votings #7099
Closed
5 tasks
@orlera orlera force-pushed the feat/manage-votings branch 2 times, most recently from 1f456a8 to 95c051d Compare January 15, 2021 21:49
@orlera orlera added project: e-voting Barcelona City Council contract space: votings labels Jan 18, 2021
@orlera orlera force-pushed the feat/manage-votings branch 2 times, most recently from 484f55d to 212a102 Compare January 18, 2021 11:29
@orlera orlera mentioned this pull request Jan 18, 2021
Merged
12 tasks
@orlera orlera force-pushed the feat/manage-votings branch 3 times, most recently from 31e958a to 77f5aca Compare January 18, 2021 14:57
agustibr and others added 15 commits January 18, 2021 16:45
@orlera orlera requested review from beagleknight and leio10 January 19, 2021 14:21
@orlera orlera marked this pull request as ready for review January 19, 2021 14:21
@orlera orlera self-assigned this Jan 19, 2021
@github-actions github-actions bot mentioned this pull request Jan 19, 2021
Closed
@orlera orlera marked this pull request as draft January 19, 2021 15:21
slickepinne
slickepinne previously approved these changes Jan 19, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@slickepinne slickepinne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 👍 🎉
I just left some minor notes. 😄

@github-actions github-actions bot mentioned this pull request Jan 19, 2021
Closed
leio10
leio10 previously approved these changes Jan 20, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@leio10 leio10 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marvelous work! 💎 🔝

@orlera orlera mentioned this pull request Jan 20, 2021
Closed
5 tasks
Base automatically changed from feat/add_votings_space to develop January 22, 2021 10:53
@mrcasals mrcasals dismissed stale reviews from leio10 and slickepinne January 22, 2021 10:53

The base branch was changed.

@orlera
Copy link
Copy Markdown
Contributor Author

orlera commented Jan 22, 2021 •
edited
Loading

Hi @decidim/mantainers. This PR has been approved by product and is ready for review 👍

@orlera orlera marked this pull request as ready for review January 22, 2021 13:54
agustibr
agustibr previously approved these changes Jan 25, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@agustibr agustibr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 😀

Just spotted some typos

mrcasals
mrcasals approved these changes Jan 25, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@mrcasals mrcasals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job!!

decidim-elections/spec/cells/decidim/votings/voting_m_cell_spec.rb
require "decidim/core/test/shared_examples/space_cell_changes_button_text_cta"

module Decidim::Votings
describe VotingMCell, type: :cell do
Copy link
Copy Markdown
Contributor

@mrcasals mrcasals Jan 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely, thank you! ❤️

@mrcasals mrcasals merged commit 2f01b14 into develop Jan 25, 2021
@mrcasals mrcasals deleted the feat/manage-votings branch January 25, 2021 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@beagleknight beagleknight Awaiting requested review from beagleknight

5 more reviewers

@qlty-cloud-legacy qlty-cloud-legacy[bot] qlty-cloud-legacy[bot] left review comments

@mrcasals mrcasals mrcasals approved these changes

@agustibr agustibr agustibr left review comments

@leio10 leio10 leio10 left review comments

@slickepinne slickepinne slickepinne left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@orlera orlera

Labels

module: elections project: e-voting Barcelona City Council contract

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Publish and unpublish a voting Manage votings

5 participants

@orlera @agustibr @leio10 @mrcasals @slickepinne