Skip to content

Fix editor image alt tag#6920

Merged
Leusev merged 3 commits intodecidim:developfrom
mainio:fix/editor-image-alt-tag
Dec 4, 2020
Merged

Fix editor image alt tag#6920
Leusev merged 3 commits intodecidim:developfrom
mainio:fix/editor-image-alt-tag

Conversation

@lahdeero
Copy link
Copy Markdown
Contributor

@lahdeero lahdeero commented Nov 24, 2020

🎩 What? Why?

Currently, it is possible to add images using rich text editor (quill) and browser's inspector, but when opening content (with quill) that includes img tag(s), images and their attributes disappear.

📌 Related Issues

Link your PR to an issue

  • Related to #?
  • Fixes #?

Testing

Describe the best way to test or validate your PR.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

@ahukkanen
Copy link
Copy Markdown
Contributor

ahukkanen commented Nov 25, 2020

Just a bit of background on this:

  • Decidim's editor does not allow images by default
  • However, 100% of our clients request to have images on the pages, impotant e.g. for guides
  • We add the images to the editors manually with browser's inspect element feature
  • The images disappear when the clients go and do edits on the pages themselves

@Leusev Leusev self-requested a review December 4, 2020 07:39
@Leusev Leusev changed the title Fix/editor image alt tag Fix editor image alt tag Dec 4, 2020
Leusev
Leusev approved these changes Dec 4, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@Leusev Leusev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In first place, as is your first contribution, thanks a lot and welcome to Decidim community @lahdeero ! 😄
Good catch here! 👍

@Leusev Leusev merged commit 866b145 into decidim:develop Dec 4, 2020
@ahukkanen ahukkanen deleted the fix/editor-image-alt-tag branch December 4, 2020 14:00
ahukkanen pushed a commit to mainio/decidim that referenced this pull request Dec 4, 2020
@lahdeero @ahukkanen
Fix editor image alt tag (decidim#6920)
b346bc5 
* Fix disappearance of alt attributes

* Added test for imagetag and alt attribute

* Attribute -> attributes

Co-authored-by: Eero Lahdenperä <eero.lahdenpera@mainiotech.fi>
@ahukkanen ahukkanen mentioned this pull request Dec 4, 2020
Merged
12 tasks
ivan-mr pushed a commit that referenced this pull request Dec 10, 2020
@ahukkanen @lahdeero
Fix editor image alt tag (#6920) (#6990)
7566625 
* Fix disappearance of alt attributes

* Added test for imagetag and alt attribute

* Attribute -> attributes

Co-authored-by: Eero Lahdenperä <eero.lahdenpera@mainiotech.fi>

Co-authored-by: Eero Lahdenperä <eero.lahdenpera@gmail.com>
Co-authored-by: Eero Lahdenperä <eero.lahdenpera@mainiotech.fi>
mrcasals pushed a commit that referenced this pull request Feb 1, 2021
@lahdeero @mrcasals
Fix editor image alt tag (#6920)
ec9ce08 
* Fix disappearance of alt attributes

* Added test for imagetag and alt attribute

* Attribute -> attributes

Co-authored-by: Eero Lahdenperä <eero.lahdenpera@mainiotech.fi>
@mrcasals mrcasals mentioned this pull request Feb 1, 2021
Merged
mrcasals added a commit that referenced this pull request Feb 2, 2021
@mrcasals @lahdeero
Fix editor image alt tag (#6920) (#7260)
2aa6355 
Co-authored-by: Eero Lahdenperä <eero.lahdenpera@mainiotech.fi>
Co-authored-by: Eero Lahdenperä <eero.lahdenpera@gmail.com>
@mrcasals mrcasals added type: fix PRs that implement a fix for a bug and removed type: bug labels Feb 26, 2021
@ahukkanen ahukkanen mentioned this pull request Jan 16, 2023
Merged
19 tasks
@ahukkanen ahukkanen mentioned this pull request Mar 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Leusev Leusev Leusev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

in-review module: admin module: core type: fix PRs that implement a fix for a bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lahdeero @ahukkanen @Leusev @mrcasals