Skip to content

Backport "Fix editor image alt tag" to 0.23#6990

Merged
ivan-mr merged 1 commit intodecidim:release/0.23-stablefrom
mainio:backport/6920
Dec 10, 2020
Merged

Backport "Fix editor image alt tag" to 0.23#6990
ivan-mr merged 1 commit intodecidim:release/0.23-stablefrom
mainio:backport/6920

Conversation

@ahukkanen
Copy link
Copy Markdown
Contributor

@ahukkanen ahukkanen commented Dec 4, 2020 •
edited
Loading

🎩 What? Why?

Backports the fix from #6920 to 0.23.

📌 Related Issues

Testing

Add an img tag manually to the content and reload the page that shows the editor.

📋 Checklist

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

@lahdeero @ahukkanen
Fix editor image alt tag (decidim#6920)
b346bc5 
* Fix disappearance of alt attributes

* Added test for imagetag and alt attribute

* Attribute -> attributes

Co-authored-by: Eero Lahdenperä <eero.lahdenpera@mainiotech.fi>
@oliverbarnes
Copy link
Copy Markdown
Contributor

oliverbarnes commented Dec 7, 2020

Looks good to me :)

@ivan-mr ivan-mr self-assigned this Dec 10, 2020
@ivan-mr ivan-mr self-requested a review December 10, 2020 23:12
ivan-mr
ivan-mr approved these changes Dec 10, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@ivan-mr ivan-mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ahukkanen for the backport. Great job!

@ivan-mr ivan-mr merged commit 7566625 into decidim:release/0.23-stable Dec 10, 2020
@ahukkanen ahukkanen deleted the backport/6920 branch August 18, 2022 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ivan-mr ivan-mr ivan-mr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ivan-mr ivan-mr

Labels

in-review module: admin module: core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ahukkanen @oliverbarnes @ivan-mr @lahdeero