Skip to content

Improve highlights of Process Groups#6828

Merged
tramuntanal merged 10 commits intodevelopfrom
feature/process_groups_improvements-highlighted_groups
Dec 9, 2020
Merged

Improve highlights of Process Groups#6828
tramuntanal merged 10 commits intodevelopfrom
feature/process_groups_improvements-highlighted_groups

Conversation

@entantoencuanto
Copy link
Copy Markdown
Contributor

🎩 What? Why?

  • Adds a promoted flag to Decidim::ParticipatoryProcessGroup model, false by default
  • Adds management of this attribute on groups admin panel
  • Displays promoted groups on processes index and shows a CTA button if defined as a content block on group landing page
  • Adds some system tests in participatory process group landing page

Note: This PR is built on top of feature/process_groups_improvements-edit_link, the branch of #6827 PR.

📌 Related Issues

Link your PR to an issue

Testing

Mark as promoted some participatory process groups and add a CTA section on landing page of one at least. Visit the participatory processes index

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

@entantoencuanto entantoencuanto force-pushed the feature/process_groups_improvements-highlighted_groups branch 3 times, most recently from 64e8561 to ceb5f69 Compare November 10, 2020 16:09
border-right: $card-border;
border-right: 0;
border-bottom: $card-border;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't leave trailing whitespace

border-right: $card-border;
border-right: 0;
border-bottom: $card-border;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected whitespace at end of line (no-eol-whitespace)

@entantoencuanto entantoencuanto force-pushed the feature/process_groups_improvements-highlighted_groups branch from ceb5f69 to b8e7b8e Compare November 11, 2020 16:37
@entantoencuanto entantoencuanto force-pushed the feature/process_groups_improvements-highlighted_groups branch from b4c68a6 to bfb4f87 Compare November 16, 2020 15:58
@entantoencuanto entantoencuanto marked this pull request as ready for review November 16, 2020 18:19
@andreslucena andreslucena changed the title Feature/process groups improvements highlighted groups Improve highlights of Process Groups Nov 18, 2020
@entantoencuanto entantoencuanto force-pushed the feature/process_groups_improvements-highlighted_groups branch 2 times, most recently from 34f018d to c8434a5 Compare November 30, 2020 19:12
@tramuntanal tramuntanal changed the base branch from develop to feature/process_groups_improvements-edit_link December 4, 2020 07:52
@tramuntanal
Copy link
Copy Markdown
Contributor

Can you rebase please with feature/process_groups_improvements-edit_link ? @entantoencuanto

* Add test to check groups editable for admins
* Add admin edit link to group landing page
@entantoencuanto entantoencuanto force-pushed the feature/process_groups_improvements-edit_link branch from a401ade to 1de2817 Compare December 4, 2020 20:30
@entantoencuanto entantoencuanto force-pushed the feature/process_groups_improvements-highlighted_groups branch from 6c9ebfe to a3caf92 Compare December 4, 2020 20:39
@entantoencuanto
Copy link
Copy Markdown
Contributor Author

Rebased

@entantoencuanto
Copy link
Copy Markdown
Contributor Author

Rebased

Base automatically changed from feature/process_groups_improvements-edit_link to develop December 9, 2020 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Highlight processes groups on processes list

4 participants