Edit link in groups and show group in processes#6827
Merged
tramuntanal merged 4 commits intodevelopfrom Dec 9, 2020
Merged
Conversation
12 tasks
e67adf2 to
fb97d2c
Compare
| border-right: $card-border; | ||
| border-right: 0; | ||
| border-bottom: $card-border; | ||
|
|
There was a problem hiding this comment.
Don't leave trailing whitespace
| border-right: $card-border; | ||
| border-right: 0; | ||
| border-bottom: $card-border; | ||
|
|
There was a problem hiding this comment.
Unexpected whitespace at end of line (no-eol-whitespace)
fb97d2c to
1caae7a
Compare
Contributor
|
There are conflicts to be resolved @entantoencuanto |
f2bbb5f to
b1ebe5f
Compare
tramuntanal
reviewed
Dec 3, 2020
Contributor
tramuntanal
left a comment
There was a problem hiding this comment.
I started to review but there are so many repeated changes that's better to wait for #6826 to be merged.
12 tasks
Contributor
|
Can you rebase please with |
* Add test to check groups editable for admins * Add admin edit link to group landing page
a401ade to
1de2817
Compare
Contributor
Author
|
Rebased |
tramuntanal
approved these changes
Dec 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Note: This PR is built on top of
feature/process_groups_improvements-participatory_processes_content_block, the branch of #6826 PR, but the changes introduced here are independent so they can be moved to a branch based ondevelopif necessary📌 Related Issues
Link your PR to an issue
Testing
As admin visit the public page of a participatory process group
Visit the public page of a participatory process which belongs to a group
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots
Please add screenshots of the changes you're proposing
