Let the file validator humanizer work with static numeric values#6682
Merged
tramuntanal merged 1 commit intodecidim:developfrom Oct 15, 2020
Merged
Conversation
tramuntanal
approved these changes
Oct 15, 2020
tramuntanal
pushed a commit
that referenced
this pull request
Oct 15, 2020
12 tasks
tramuntanal
added a commit
that referenced
this pull request
Oct 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
The file validator humanizer is not currently working when given static numeric values. It only works with lambdas as it is being used in the Decidim core. This ensures it works also with numbers.
📌 Related Issues
Testing
There's nothing in the core that is currently broken because of this but this will fix situations where static numbers are used to limit the file sizes.
📋 Checklist
docs/.