Backport "Fix the file validator humanizer with static numeric values" to 0.23#6688
Merged
tramuntanal merged 1 commit intorelease/0.23-stablefrom Oct 16, 2020
Conversation
ivan-mr
approved these changes
Oct 15, 2020
ivan-mr
suggested changes
Oct 15, 2020
Contributor
ivan-mr
left a comment
There was a problem hiding this comment.
There're some lint errors? Please can you change them
Leusev
suggested changes
Oct 16, 2020
Contributor
Leusev
left a comment
There was a problem hiding this comment.
Hi @tramuntanal
The failing test [CI] Meetings, seems to be the flaky one, but the other 2, [CI] Comments & [CI] Lint are a bit weird..
Contributor
Author
|
I'm re-running them |
Leusev
approved these changes
Oct 16, 2020
Contributor
Leusev
left a comment
There was a problem hiding this comment.
Seems ok now @tramuntanal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Please describe your pull request.
Backport #6682 to
release/0.23-stable.📌 Related Issues
Link your PR to an issue
Testing
Describe the best way to test or validate your PR.
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots
Please add screenshots of the changes you're proposing
