Filter created initiatives only by author#6658
Merged
tramuntanal merged 6 commits intodevelopfrom Nov 11, 2020
Merged
Conversation
oriolgual
reviewed
Oct 14, 2020
decidim-initiatives/app/services/decidim/initiatives/initiative_search.rb
Outdated
Show resolved
Hide resolved
beagleknight
previously approved these changes
Oct 14, 2020
decidim-initiatives/app/services/decidim/initiatives/initiative_search.rb
Outdated
Show resolved
Hide resolved
Contributor
|
@marinavega I've re-run tests from 4 modules that were stuck: verifications, system, consultations and admin. |
tramuntanal
reviewed
Oct 15, 2020
Contributor
tramuntanal
left a comment
There was a problem hiding this comment.
Hi @marinavega
LGTM but I have a question regarding the filter queries
decidim-initiatives/app/services/decidim/initiatives/initiative_search.rb
Outdated
Show resolved
Hide resolved
Contributor
|
Hi @marinavega , waiting for response 😄 |
oriolgual
approved these changes
Nov 4, 2020
edgarlatorre
pushed a commit
that referenced
this pull request
Nov 11, 2020
* Remove draft state filter and show created inititives only by author * Remove unused key * Properly filter by author * Fix offense * Reuse query when filtering by author * Formatting
edgarlatorre
pushed a commit
that referenced
this pull request
Nov 11, 2020
* Remove draft state filter and show created inititives only by author * Remove unused key * Properly filter by author * Fix offense * Reuse query when filtering by author * Formatting
edgarlatorre
pushed a commit
that referenced
this pull request
Nov 12, 2020
* Remove draft state filter and show created inititives only by author * Remove unused key * Properly filter by author * Fix offense * Reuse query when filtering by author * Formatting
edgarlatorre
pushed a commit
that referenced
this pull request
Nov 16, 2020
* Remove draft state filter and show created inititives only by author * Remove unused key * Properly filter by author * Fix offense * Reuse query when filtering by author * Formatting
tramuntanal
pushed a commit
that referenced
this pull request
Nov 18, 2020
* Create public page for editing initiative * Add print initiative * Add public page for committee members * public page for send technical validation * Style adjusments * Fix initiative_committee_action permission * Change confirm send to technical validation text * Fix create initiative test * Fix edit initiative with area * Add permission to print and improve permission for committee * Add tests for area_updatable? * Add missing translations * Add missing locale * Filter created initiatives only by author (#6658) * Remove draft state filter and show created inititives only by author * Remove unused key * Properly filter by author * Fix offense * Reuse query when filtering by author * Formatting * Remove old text from completed initiative page * Create default minimum of committee members * Remove print permissions and add print to show page * Fix search by state closed and open * Remove print button from edit page * Remove permission to user access initiatives on admin * Fix filter by author * Fix send my initiative link and some tests * Remove test for author on admin * Fix state params when it is nil * Fix initiatives warning * Fix copy button position * Add more tests for permissions Co-authored-by: Marina <marina@codegram.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Removes
draftstate filter and shows all initiatives (published and not published) when filtering bymy initiatives.This PR updates the changes added in #6584 after a redefinition of the feature.
📌 Related Issues
🟢 Testing
The functionality can be tested in this review app.
📋 Checklist
draftstate filtersearch_authorquerystatewhen filtering by My initiatives📷 Screenshots