Conversation
11 tasks
11 tasks
edgarlatorre
reviewed
Oct 6, 2020
decidim-initiatives/app/services/decidim/initiatives/initiative_search.rb
Outdated
Show resolved
Hide resolved
edgarlatorre
previously approved these changes
Oct 6, 2020
Contributor
edgarlatorre
left a comment
There was a problem hiding this comment.
It looks good to me! Just left one comment
ivan-mr
suggested changes
Oct 6, 2020
Contributor
ivan-mr
left a comment
There was a problem hiding this comment.
Everything seems ok, but I would like to ask if you could do the tests that currently fail the codecov/patch.
Also if you could implement the comment about the query it would be great.
Thanks!
ivan-mr
approved these changes
Oct 8, 2020
Contributor
ivan-mr
left a comment
There was a problem hiding this comment.
Everything seems ok. Thanks @marinavega !
This was referenced Oct 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
As a promoter of an Initiative, I can see my drafted Initiatives.
📌 Related Issues
Testing
The functionality can be tested in this review app.
Draft📋 Checklist
📷 Screenshots