Fix meeting and debate presenters with machine translations#6643
Merged
tramuntanal merged 3 commits intodevelopfrom Oct 8, 2020
Merged
Fix meeting and debate presenters with machine translations#6643tramuntanal merged 3 commits intodevelopfrom
tramuntanal merged 3 commits intodevelopfrom
Conversation
tramuntanal
reviewed
Oct 8, 2020
Contributor
tramuntanal
left a comment
There was a problem hiding this comment.
Hi @mrcasals thanks for the fix,
quick question, why ProposalPresenter is using Decidim::TranslatableAttributes and DebatePresenter and MeetingPresenter is using an internal handle_locales method?
Isn't the same situation? can we reuse code?
Contributor
Author
|
@tramuntanal I don't know. I tried to keep the same behaviour but fixing the problem. |
Contributor
|
ok, @mrcasals lets merge the fix, but it will be great if some of the developers of the machine translations system can answer the question. I think to remember they were @oriolgual and @anaghavl |
Contributor
|
This is inn, we're taking care of the backport to |
tramuntanal
pushed a commit
that referenced
this pull request
Oct 8, 2020
* Handle machine translations at Meeting and Debate presenters * Add specs * Lint files
12 tasks
tramuntanal
added a commit
that referenced
this pull request
Oct 8, 2020
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
These presenters are broken after adding machine translations. It only affects installations using machine translations.
📌 Related Issues
None
Testing
Have a meeeting or a debate with machine translations. They fail when presented without this PR.
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots
None