Skip to content

Backport "Fix meeting and debate presenters with machine translations" to 0.23-stable#6647

Merged
tramuntanal merged 1 commit intorelease/0.23-stablefrom
backport/fix/meeting-presenter
Oct 8, 2020
Merged

Backport "Fix meeting and debate presenters with machine translations" to 0.23-stable#6647
tramuntanal merged 1 commit intorelease/0.23-stablefrom
backport/fix/meeting-presenter

Conversation

@tramuntanal
Copy link
Copy Markdown
Contributor

🎩 What? Why?

Please describe your pull request.
Backports #6643 to what's going to be 0.23.0.rc1 by cerry-picking the commit into release/0.23-stable.

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

* Handle machine translations at Meeting and Debate presenters

* Add specs

* Lint files
Copy link
Copy Markdown
Contributor

@Leusev Leusev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, looks good for me, as it would be same question as original PR #6643

@tramuntanal tramuntanal merged commit 37dc0dd into release/0.23-stable Oct 8, 2020
@tramuntanal tramuntanal deleted the backport/fix/meeting-presenter branch October 8, 2020 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants