Skip to content

Fix bugs after proposals i18n move#6384

Merged
tramuntanal merged 3 commits intodevelopfrom
fix/proposals-i18n-bugs
Aug 6, 2020
Merged

Fix bugs after proposals i18n move#6384
tramuntanal merged 3 commits intodevelopfrom
fix/proposals-i18n-bugs

Conversation

@mrcasals
Copy link
Copy Markdown
Contributor

@mrcasals mrcasals commented Aug 6, 2020

🎩 What? Why?

#6285 added i18n to proposals. This caused some bugs that were not caught at the time, but are fixed by this PR.

📌 Related Issues

None

📋 Subtasks

None

@mrcasals mrcasals self-assigned this Aug 6, 2020
@mrcasals mrcasals changed the title Fixx bugs after proposals i18n move Fix bugs after proposals i18n move Aug 6, 2020
@mrcasals
Copy link
Copy Markdown
Contributor Author

mrcasals commented Aug 6, 2020

@decidim/core this PR fixes a bug when importing proposals to a budget. It's related to #6285 and it slipped our tests.

I'm warning about this because this might be needed for the upcoming release!

@tramuntanal tramuntanal self-assigned this Aug 6, 2020
@tramuntanal tramuntanal merged commit a3f3dfd into develop Aug 6, 2020
@tramuntanal tramuntanal deleted the fix/proposals-i18n-bugs branch August 6, 2020 09:55
Quentinchampenois pushed a commit to Quentinchampenois/decidim that referenced this pull request Aug 14, 2020
* Translte proposal title for amendments on component seeds

* Fix bug on importing proposals to budgets

* Fix tests
@mrcasals mrcasals mentioned this pull request Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants