Merged
Conversation
mrcasals
reviewed
Aug 10, 2020
ivan-mr
previously approved these changes
Aug 13, 2020
Leusev
approved these changes
Aug 13, 2020
Contributor
Leusev
left a comment
There was a problem hiding this comment.
It was advisable to add a spec test for the Last Activity Cards shorten text
Now all is ok
tramuntanal
commented
Aug 13, 2020
Contributor
Author
tramuntanal
left a comment
There was a problem hiding this comment.
The test is good @Leusev 👍
tramuntanal
added a commit
that referenced
this pull request
Aug 13, 2020
* Declare colors for filter button
* Call organization_colors inside decidim-admin
* Different translations for proposals' states and initiatives' state
* Re-fix by having totally different i18n scopes for proposals and initiatives
* Fix color links on author_name and hide/show replies and reply links
* Fix misaligned error on proposal cards
* Fix lint code on filterable_helper
* Fix truncate not applied in Last Activity cards
* Fix missing username in last activity cards for proposals
* Fix endorsements list 'and X more people' doesn't behave correctly
* Fix random indent style in conversations and notifications
* Let i18n_ctx be optional
* Delete commented tags
* Remove "for %{resource_name}" in Version Control and Fingerprint
* Remove trailing ")" in related assemblies
* Fix unexpected whitespace before "{" in scss
* Remove argument due to method signature
* Fix [CI] Proposals (unit tests) / Tests (pull_request)
* Add last activity card shorten text spec
Co-authored-by: Ivan Molinero <ivan.mr@coditramuntana.com>
Co-authored-by: Ramon Costa <ramon.costa@gmail.com>
tramuntanal
added a commit
that referenced
this pull request
Aug 13, 2020
* Bugfix 0.22.0.rc1 (#6381) * Declare colors for filter button * Call organization_colors inside decidim-admin * Different translations for proposals' states and initiatives' state * Re-fix by having totally different i18n scopes for proposals and initiatives * Fix color links on author_name and hide/show replies and reply links * Fix misaligned error on proposal cards * Fix lint code on filterable_helper * Fix truncate not applied in Last Activity cards * Fix missing username in last activity cards for proposals * Fix endorsements list 'and X more people' doesn't behave correctly * Fix random indent style in conversations and notifications * Let i18n_ctx be optional * Delete commented tags * Remove "for %{resource_name}" in Version Control and Fingerprint * Remove trailing ")" in related assemblies * Fix unexpected whitespace before "{" in scss * Remove argument due to method signature * Fix [CI] Proposals (unit tests) / Tests (pull_request) * Add last activity card shorten text spec Co-authored-by: Ivan Molinero <ivan.mr@coditramuntana.com> Co-authored-by: Ramon Costa <ramon.costa@gmail.com> * Fix last activity card test * Fix test Co-authored-by: Ivan Molinero <ivan.mr@coditramuntana.com> Co-authored-by: Ramon Costa <ramon.costa@gmail.com>
Quentinchampenois
pushed a commit
to Quentinchampenois/decidim
that referenced
this pull request
Aug 14, 2020
* Declare colors for filter button
* Call organization_colors inside decidim-admin
* Different translations for proposals' states and initiatives' state
* Re-fix by having totally different i18n scopes for proposals and initiatives
* Fix color links on author_name and hide/show replies and reply links
* Fix misaligned error on proposal cards
* Fix lint code on filterable_helper
* Fix truncate not applied in Last Activity cards
* Fix missing username in last activity cards for proposals
* Fix endorsements list 'and X more people' doesn't behave correctly
* Fix random indent style in conversations and notifications
* Let i18n_ctx be optional
* Delete commented tags
* Remove "for %{resource_name}" in Version Control and Fingerprint
* Remove trailing ")" in related assemblies
* Fix unexpected whitespace before "{" in scss
* Remove argument due to method signature
* Fix [CI] Proposals (unit tests) / Tests (pull_request)
* Add last activity card shorten text spec
Co-authored-by: Ivan Molinero <ivan.mr@coditramuntana.com>
Co-authored-by: Ramon Costa <ramon.costa@gmail.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Aggregates some of the small bugfixes found in v0.22.0.rc1.
📌 Related Issues
📋 Subtasks
CHANGELOGupgrade notes, if required📷 Screenshots (optional)
1. Admin filter button not visible
2. Admin filters values in Proposals
3. Metrics admin panel shown in black
4. Truncate not applied in Last Activity cards
5. Remove "for %{resource_name}" in Version Control and Fingerprint
6. Missing link styles
In show/hide replies
In Usernames
7. Missing username in last activity cards for proposals
8. Random indent style in conversations and notifications
9. Username and title misaligned in proposal cards
10. Related assemblies
13. Endorsements list "and X more people" doesn't behave correctly