Skip to content

Backport "Bugfix 0.22.0.rc1" to v0.22#6401

Merged
tramuntanal merged 3 commits intorelease/0.22-stablefrom
backport/fix/0.22.0.rc1
Aug 13, 2020
Merged

Backport "Bugfix 0.22.0.rc1" to v0.22#6401
tramuntanal merged 3 commits intorelease/0.22-stablefrom
backport/fix/0.22.0.rc1

Conversation

@tramuntanal
Copy link
Copy Markdown
Contributor

@tramuntanal tramuntanal commented Aug 13, 2020

🎩 What? Why?

Backports to release/0.22-stable the fixes for the bugs found when deploying v0.22.0.rc1 to meta-decidim.

📌 Related Issues

* Declare colors for filter button

* Call organization_colors inside decidim-admin

* Different translations for proposals' states and initiatives' state

* Re-fix by having totally different i18n scopes for proposals and initiatives

* Fix color links on author_name and hide/show replies and reply links

* Fix misaligned error on proposal cards

* Fix lint code on filterable_helper

* Fix truncate not applied in Last Activity cards

* Fix missing username in last activity cards for proposals

* Fix endorsements list 'and X more people' doesn't behave correctly

* Fix random indent style in conversations and notifications

* Let i18n_ctx be optional

* Delete commented tags

* Remove "for %{resource_name}" in Version Control and Fingerprint

* Remove trailing ")" in related assemblies

* Fix unexpected whitespace before "{" in scss

* Remove argument due to method signature

* Fix [CI] Proposals (unit tests) / Tests (pull_request)

* Add last activity card shorten text spec

Co-authored-by: Ivan Molinero <ivan.mr@coditramuntana.com>
Co-authored-by: Ramon Costa <ramon.costa@gmail.com>
@tramuntanal tramuntanal linked an issue Aug 13, 2020 that may be closed by this pull request
13 tasks
@Leusev Leusev self-requested a review August 13, 2020 09:42
Copy link
Copy Markdown
Contributor

@Leusev Leusev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen that this error is related to Last Activity Card shorten text rspec added:
image
it seems that translated_body for comments isn't available in release/0.22-stable branch
image
I'll try to change it

@Leusev Leusev self-requested a review August 13, 2020 14:41
Copy link
Copy Markdown
Contributor

@Leusev Leusev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, as seen before, all seems ok here too

@tramuntanal tramuntanal merged commit e602b75 into release/0.22-stable Aug 13, 2020
@tramuntanal tramuntanal deleted the backport/fix/0.22.0.rc1 branch August 13, 2020 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bugfixing 0.22.0.rc1

3 participants