Remove relations between user and spaces on destroy account command#6041
Merged
tramuntanal merged 13 commits intodevelopfrom May 8, 2020
Merged
Conversation
…nd_spaces_on_destroy_command
…nd_spaces_on_destroy_command
…nd_spaces_on_destroy_command
tramuntanal
reviewed
Apr 30, 2020
Contributor
tramuntanal
left a comment
There was a problem hiding this comment.
We should extract external code from core
CHANGELOG.md
Outdated
| - **decidim-core**: Do not leak image processing errors [\#5553](https://github.com/decidim/decidim/pull/5553) | ||
| - **decidim-core**, **decidim-proposals**, **decidim-participatory_processes**, **decidim-meetings**, **decidim-sortitions**: XSS sanitization [\#5553](https://github.com/decidim/decidim/pull/5553) | ||
| - **decidim-core**: Fix the scopes picker rendereding escaped characters [#5939](https://github.com/decidim/decidim/pull/5939) | ||
| - **decidim-core**: Fix the destroy account command removing relations with spaces [#6041](https://github.com/decidim/decidim/pull/6041) |
Contributor
There was a problem hiding this comment.
Suggested change
| - **decidim-core**: Fix the destroy account command removing relations with spaces [#6041](https://github.com/decidim/decidim/pull/6041) | |
| - **decidim-core**: Fix the destroy account command removing relations with spaces [\#6041](https://github.com/decidim/decidim/pull/6041) |
| end | ||
|
|
||
| def destroy_conference_speaker | ||
| Decidim::ConferenceSpeaker.where(user: @user).destroy_all |
Contributor
There was a problem hiding this comment.
If the conferences module is not enabled, this will crash. Also core should not depend upon other modules
| require "decidim/participatory_processes/test/factories" | ||
| require "decidim/assemblies/test/factories" | ||
| require "decidim/comments/test/factories" | ||
| require "decidim/conferences/test/factories" |
Contributor
There was a problem hiding this comment.
We should avoid adding external dependencies to core, even for testing, we should extract those tests to their corresponding modules
… an account is removed
…nd_spaces_on_destroy_command
…nd_spaces_on_destroy_command
Contributor
Author
|
Hi @decidim/product , |
Member
|
@ivan-mr I've checked it on staging, with both Assemblies and Conferences, LGTM! 👍 |
6 tasks
ace
pushed a commit
to aspgems/decidim
that referenced
this pull request
May 12, 2020
* feature/initiatives_search_fo_new_design: Updates changelog Harmonizes the design of initiatives search in FO New question type "Matrix" in questionnaires (decidim#5948) Add filter options to Timeline and Activity tabs (decidim#5845) Remove relations between user and spaces on destroy account command (decidim#6041) Explain how to initialize a custom oauth2 client provider (decidim#6055) Reenable main tests on Crowdin PRs (decidim#6076) Enum and readonly component settings (decidim#6001) New Crowdin translations (decidim#6066) Add missing notifications (decidim#5906)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
When a User remove his own account, the relations with spaces aren't removed. This feature add the capability of removing this relations
📌 Related Issues
📋 Subtasks
CHANGELOGentry