Merged
Conversation
7 tasks
83247e2 to
a8f1c8d
Compare
815ffeb to
9bcaac9
Compare
….com/decidim/decidim into feature/5781-add_missing_notifications
Contributor
Author
|
Hi @decidim/product , this PR has been deployed into our staging and can now be checked |
6ac85f9 to
e26eaa2
Compare
Contributor
Author
|
Hi @decidim/product , this is still pending to be checked |
In order to differentiate it from the participants invited to a private assembly.
jesusdb
previously approved these changes
May 5, 2020
Leusev
suggested changes
May 5, 2020
Contributor
Leusev
left a comment
There was a problem hiding this comment.
Good job @tramuntanal, except for the comment I left, with deleted method, all other seems all right
decidim-initiatives/app/mailers/decidim/initiatives/initiatives_mailer.rb
Show resolved
Hide resolved
….com/decidim/decidim into feature/5781-add_missing_notifications
Leusev
approved these changes
May 5, 2020
Contributor
Leusev
left a comment
There was a problem hiding this comment.
Perfect @tramuntanal . Its seems ok for me
ace
pushed a commit
to aspgems/decidim
that referenced
this pull request
May 12, 2020
* feature/initiatives_search_fo_new_design: Updates changelog Harmonizes the design of initiatives search in FO New question type "Matrix" in questionnaires (decidim#5948) Add filter options to Timeline and Activity tabs (decidim#5845) Remove relations between user and spaces on destroy account command (decidim#6041) Explain how to initialize a custom oauth2 client provider (decidim#6055) Reenable main tests on Crowdin PRs (decidim#6076) Enum and readonly component settings (decidim#6001) New Crowdin translations (decidim#6066) Add missing notifications (decidim#5906)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR adds the missing notifications defined in #5781 .
📌 Related Issues
📋 Subtasks
CHANGELOGentry📷 Screenshots (optional)
As a participant I receive a notification when there's a new comment by a group
As a participant I receive a notification when I've been invited as a member of an assembly
As an admin I receive a notification when a group has been created
As an admin I receive a notification when a group has updated its profile and has been left unverified
As an admin I receive a notification when an initiative is sent to technical validation
As an admin, or a valuator, I receive a notification when someone leaves a private note on a proposal