Closed
Conversation
2 tasks
5 tasks
This was referenced Apr 6, 2020
Merged
13508fa to
5004c1f
Compare
* Add changelog entry * feat: add parent/child relationship to components * feat: add settings to define if a component can have parent or children * feat(admin): add parent field to component form when allowed * refactor(admin): enforce the use of participatory space context concern * refactor(admin): unify the menu components list rendering * feat(admin): hide child components from lists * feat(front): hide child components from lists * feat: add the budgets groups component to the budgets module * feat: allow budget components to have a parent component * feat(admin): allow budgets group admin to manage children components * feat(front): show children components on budget group index page * style: fix lint issues * test: fix tests broken with refactor * Fix CI config for consultations * Fix CI config A single asterisk only matches branch names *without* slashes. Double asterisk will match any branch name including slashes. * Fix liinter complaints * Add missing method on consultations * Fix conferences tests * Add missing field on test double * Don't make budgets groups engine load tasks * Lint files * Use correct consultations questions admin layout * feat: budgets group view improvements * Fix lint errors Co-authored-by: Marc Riera Casals <mrc2407@gmail.com> Co-authored-by: Agustí B.R <agusti@codegram.com>
6bc468e to
0866f66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR group all the PR related to the improvement of the budgets component.
📌 Related Issues
📋 Subtasks
📷 Screenshots (optional)