Skip to content

Fix tags linebreak#5751

Merged
agustibr merged 2 commits intofeature/admin-scopes-bulk-actionfrom
fix/tags_linebreak
Feb 20, 2020
Merged

Fix tags linebreak#5751
agustibr merged 2 commits intofeature/admin-scopes-bulk-actionfrom
fix/tags_linebreak

Conversation

@leio10
Copy link
Copy Markdown
Contributor

@leio10 leio10 commented Feb 17, 2020

🎩 What? Why?

Adds missing class for tags container.

📌 Related Issues

📋 Subtasks

  • Add CHANGELOG entry
  • Add documentation regarding the feature
  • Add/modify seeds
  • Add tests
  • Another subtask

📷 Screenshots (optional)

Description

@leio10 leio10 requested review from agustibr and mrcasals February 17, 2020 18:13
agustibr
agustibr previously approved these changes Feb 18, 2020
@leio10
Copy link
Copy Markdown
Contributor Author

leio10 commented Feb 18, 2020

@decidim/core this is ready to be merged, I think that it's too small to need a changelog entry or extra tests

mrcasals
mrcasals previously approved these changes Feb 19, 2020
@agustibr
Copy link
Copy Markdown
Contributor

@leio10 you can consider changing the base branch to merge this PR into feature/admin-scopes-bulk-action (PR #5759), as it is also involved with tags and depends on this PR to show properly the changed scope in the proposal details.
I expect to have PR #5759 ready for review soon. 😸

@leio10 leio10 dismissed stale reviews from mrcasals and agustibr via edf7029 February 20, 2020 10:46
@leio10 leio10 force-pushed the fix/tags_linebreak branch from 5690964 to edf7029 Compare February 20, 2020 10:46
@leio10 leio10 changed the base branch from develop to feature/admin-scopes-bulk-action February 20, 2020 10:47
@leio10
Copy link
Copy Markdown
Contributor Author

leio10 commented Feb 20, 2020

Hi @agustibr, I've rebased the branch and changed the base branch for the PR, is this what you were asking for?

@agustibr
Copy link
Copy Markdown
Contributor

@leio, I think changing the "base branch" was ok, but this should work also.
Thanks 😄

@agustibr agustibr merged commit f4a97ac into feature/admin-scopes-bulk-action Feb 20, 2020
@agustibr agustibr deleted the fix/tags_linebreak branch February 20, 2020 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Category tags are shown next to each other and not on top of each other

3 participants