Decidim shorten Last Activity Cards's description#5742
Merged
tramuntanal merged 9 commits intodecidim:masterfrom Feb 19, 2020
Merged
Decidim shorten Last Activity Cards's description#5742tramuntanal merged 9 commits intodecidim:masterfrom
tramuntanal merged 9 commits intodecidim:masterfrom
Conversation
… to 80 chars max limit
… to 80 chars max limit
…length to 80 chars
tramuntanal
previously approved these changes
Feb 18, 2020
Contributor
|
@Leusev merge master in order to get the tests succeed please Also, there was no test regarding this already existing truncate? |
tramuntanal
approved these changes
Feb 19, 2020
microstudi
pushed a commit
to Platoniq/decidim
that referenced
this pull request
Feb 21, 2020
* [FIX] shorten 100 chars description max lenght in last activity cards to 80 chars max limit * [FIX] shorten 100 chars description max lenght in last activity cards to 80 chars max limit * [FIX] Wrong push, undone my last commit changes - My fault, sorry. * [FEAT] Shorten the 100 chars default last activity cards description length to 80 chars * [FIX] Fixed changelog issue reference * [FIX] fixed CHANGELOG desc Co-authored-by: ramoncodit <37654424+ramoncodit@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Shorten 100 default's last activity cards length description to 80 chars, in order to reduce default description to two lines.
As asked in #5672, only focusing on Desktop view.
📌 Related Issues
📋 Subtasks
CHANGELOGentry